mx4j/src/core/mx4j/server MBeanIntrospector.java,1.32,1.33

Jeremy Boynes <[email protected]> Tue, 08 Feb 2005 03:46:02 +0000
Newsgroups gmane.comp.java.mx4j.cvs
Message-ID <[email protected]>
Update of /cvsroot/mx4j/mx4j/src/core/mx4j/server
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv22509/src/core/mx4j/server

Modified Files:
	MBeanIntrospector.java 
Log Message:
Fix for [ 1115083 ] MBeanInfo missing classname is not compliant
Although our testcase says this is permissible in 1.2, it really is not
Patch applied and testcase updated

Index: MBeanIntrospector.java
===================================================================
RCS file: /cvsroot/mx4j/mx4j/src/core/mx4j/server/MBeanIntrospector.java,v
retrieving revision 1.32
retrieving revision 1.33
diff -C2 -d -r1.32 -r1.33
*** MBeanIntrospector.java	21 Nov 2004 14:06:10 -0000	1.32
--- MBeanIntrospector.java	8 Feb 2005 03:45:59 -0000	1.33
***************
*** 175,183 ****
        Logger logger = getLogger();
  
!       if (metadata.getMBeanInfo() == null)
        {
           if (logger.isEnabledFor(Logger.DEBUG)) logger.debug("MBeanInfo is null");
           return false;
        }
        return true;
     }
--- 175,189 ----
        Logger logger = getLogger();
  
!       MBeanInfo info = metadata.getMBeanInfo();
!       if (info == null)
        {
           if (logger.isEnabledFor(Logger.DEBUG)) logger.debug("MBeanInfo is null");
           return false;
        }
+       if (info.getClassName() == null)
+       {
+          if (logger.isEnabledFor(Logger.DEBUG)) logger.debug("MBeanInfo.getClassName() is null");
+          return false;
+       }
        return true;
     }



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click