RemoteNotificationClientHandler fix

Brian Scully <[email protected]>
Newsgroups gmane.comp.java.mx4j.devel
Message-ID <[email protected]>
Hello Simon,

> Brian, the fix is kinda hacky ...

Ouch.  I would agree that it's not pretty (casting
never is), which is why I called it "preliminary", but
IMO it's in the right spot.

> It is maybe worth to add start() and stop() to the
> RemoteNotificationClientHandler interface, and 
> invoke them directly like your fix suggested.

This was why I put it into the AbstractRNCH.  Because
the threading is localized to that class, why should
the interface care about it?  Now if you are telling
me that all classes that implement
RemoteNotificationClientHandler are not going to
implement it directly, but instead are going to extend
AbstractRNCH - then it might as well be carried in the
RemoteNotificationClientHandler interface.  Or the
internal type references should be of type
AbstractRNCH.

I was confused by the use of the
RemoteNotificationClientHandler interface as the type
of the references in the RMIConnector and
SOAPConnector.  Each of these has its own
implementation of RemoteNotificationClientHandler that
they require to operate properly - why not just type
the references as such?

I don't know that burdening the RNCH interface with
start/stop makes sense.  This certainly needs more
discussion.

Brian

__________________________________
Do you Yahoo!?
Yahoo! Mail SpamGuard - Read only the mail you want.
http://antispam.yahoo.com/tools


-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.