Re: Explanation of three patches checked into patches_3.1.0-beta1 branch

Allen Servedio <[email protected]> Sat, 28 Mar 2009 08:52:03 -0400
Newsgroups gmane.comp.java.mx4j.devel
Message-ID <[email protected]>
Sounds good and sorry for the delay. Long week at work :-)

I'll move the code into trunk this weekend.

Thanks!
Allen

Simone Bordet wrote:
> 2009/3/23 Allen Servedio <[email protected]>:
>   
>> Hi,
>>
>> I have checked in three patches to the patches_3.1.0-beta1 branch
>> (https://mx4j.svn.sourceforge.net/svnroot/mx4j/branches/patches_3.1.0-beta1).
>> They basically do the following to the HttpAdapter:
>>
>> 1) (Revision 2274) If an operation's parameter is of type Object, it treats
>> it as type String. The company I work for has a few MBeans with API's that
>> have Object parameters for operations that accept Strings but also a few
>> other types. This was the simplest way I saw to open up these API's for use
>> (without having to add String typed methods just to allow their use that is
>> :-) ).
>>
>> 2) (Revision 2275) The second feature I added was a check box above each
>> operation's submit button that - when checked - told the system to return
>> the raw output of a method (unescaped and with none of the MX4J navigation
>> or other UI chrome). This can be especially handy if the operation returns
>> XML that you just want to script pulling and saving (which is what we do).
>>
>> 3) (Revision 2276) The last feature I added allows people to specify an XSL
>> document to apply to the raw output of an operation (along with instructions
>> on how to use this and the second feature above).
>>
>> I broke each of these into their own revision to make it easier to see what
>> I did (esp. if the feature actually is unnecessary because of some existing
>> feature that I overlooked :-) ).
>>
>> I will next look at the existing tests in the project and see how tests can
>> be added for each of these features and do so (I apologize ahead of time for
>> not having tests in place already, but that is another reason I put these
>> changes in a branch instead of trunk). I also wanted to try to get these
>> features up for review quickly so that people could see what I was trying to
>> do and the changes could be made to have them fit the standards of this
>> project.
>>     
>
> Allen, great job and please apply to trunk, do not waste time working
> on a branch (that has later to be reported to trunk).
>
> Thanks !
>
> Simon
>

------------------------------------------------------------------------------

_______________________________________________
Mx4j-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mx4j-devel