[nanocontainer-scm] [jira] Commented: (NANO-136) Deployer Invalidly traverses too deep looking for nanoconainer.*

     [ http://jira.codehaus.org/browse/NANO-136?page=comments#action_40487 ]
     
Michael Rimov commented on NANO-136:
------------------------------------

P.S. Multiproject works now with deployer included:

Index: project.properties
===================================================================
--- project.properties	(revision 2060)
+++ project.properties	(working copy)
@@ -32,7 +32,7 @@
 maven.multiproject.aggregateDir=components/
 maven.multiproject.includes=*/project.xml
 #the following fail and therefore are excluded
-maven.multiproject.excludes=idea/project.xml,deployer/project.xml
+maven.multiproject.excludes=idea/project.xml
 maven.simian.linecount = 4
 maven.license.licenseFile=${maven.multiproject.basedir}/LICENSE.txt
 


> Deployer Invalidly traverses too deep looking for nanoconainer.*
> ----------------------------------------------------------------
>
>          Key: NANO-136
>          URL: http://jira.codehaus.org/browse/NANO-136
>      Project: NanoContainer
>         Type: Bug
>   Components: deployer
>  Environment: Windows JDK 1.5.  Using Latest SVN code.
>     Reporter: Michael Rimov
>     Priority: Minor
>  Attachments: deploy-patch.zip
>
>
> A couple of issues with deployer:
> It would:
> 1 - Search indefinitely deep and only return the first in the array.  So something in the lines of:
>     
> META-INF
>    |-nanocontainer.groovy
>    |-.svn
>        |--nanocontainer.svn.props-base
> Would return nanocontainer.svn.props-base instead of the correct file.  Fix only searches one layer deep.  (Tested against VFS's SVN source base)
> 2 - Null Pointer Exception if the wrong type of file extension is found. (Given the above case, I bet you can't figure out why I found this bug ;)  )  Fixed.
> 3 - Added test cases for badly formed jar files and badly named scripts.  (malformed-deployment.jar and badbuildscriptdeploy.jar respectively)  
> 4 - Added a constructor to NanoContainerDeployer to not have to hard code the configuration script name. (before hardcoded to 'nanocontainer') -- the old default is provided.
> The entire zip file should be able to drop into nanocontainer-sandbox\trunk\deployer\src and test case jars and patch files should match up.  I'll be happy to modify the exceptio handling as per my post to the list and/or modify anything else in the design mods.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira