[jira] Commented: (NANO-74) NanoContainer-WebWork2 to support ObjectFactory

The following comment has been added to this issue:

     Author: Cyrille Le Clerc
    Created: Sun, 16 May 2004 10:33 AM
       Body:
> 1) How does this affect backwards compatibility?

Good point, :-),

This fix is backward INCOMPATIBLE with WW 2.0 :
 
- proposed fix will break with release WW 2.0
- but existing implementation does not work with WW 2.0.1 (not yet released, still CVS HEAD) ; this fix does work

An idea may be to release a fix as soon as WW 2.0.1 is released an to keep a fix available in jira or CVS. But this may confuse users who would upgrade nanoWW2 but not WW2.x

Another idea would be to create a new (temporary ? ) package webwork201 and then have
- org.nanocontainer.webwork2.PicoServletDispatcher : the existing one
- org.nanocontainer.webwork201.PicoServletDispatcher : the new one

The new package idea may be the most explicit for the users

> 2) How does this affect the current documentation at 
> http://docs.codehaus.org/display/NANO/NanoContainer+WebWork ?

- If we keep the same package, this fix does NOT affect current doc.

- If we create a package org.nanocontainer.webwork201, this fix DOES affect the doc

> We must not forget to think about old and new users and 
> make life easy for them!
 I still have to learn many things :-)

---------------------------------------------------------------------
View this comment:
  http://jira.codehaus.org/browse/NANO-74?page=comments#action_19846

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/NANO-74

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: NANO-74
    Summary: NanoContainer-WebWork2 to support ObjectFactory
       Type: Bug

     Status: Unassigned
   Priority: Major

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: NanoContainer
 Components: 
             webwork2

   Assignee: 
   Reporter: Cyrille Le Clerc

    Created: Sat, 8 May 2004 8:50 AM
    Updated: Sun, 16 May 2004 10:33 AM
Environment: WebWork 2.1 CVS Head
XWork 1.0.1

Description:
Current NanoContainer-WebWork2 does not work with the new ObjectFactory

Here is a patch I used on my project :
- remove org.nanocontainer.webwork2.PicoActionFactory
- remove org.nanocontainer.webwork2.PicoActionProxyFactory
- modify org.nanocontainer.webwork2.PicoServletDispatcher
- create org.nanocontainer.webwork2.PicoObjectFactory
- create org.nanocontainer.webwork2.ThreadLocalContainerReference

Note : a discussion on ThreadLocalContainerReference has been held on the mailing list to know weither it should be mutualized over project.
Waiting for this answer, I developped a very specific and as simple as possible for this patch implementation.




---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira