Re: Contribution pull request?
Emilian Bold <[email protected]> Wed, 18 Jan 2017 15:26:32 +0200
| Newsgroups | gmane.comp.java.netbeans.devel |
|---|---|
| Message-ID | <CAL6R17Btt82nU6WHBF6a685Y+PvRDSUQJkUr9t6yHNOGFE4hwQ@mail.gmail.com> |
Yes, I remember your patch. I've also just subscribed to the issue. The patch is quite clean, although I don't personally like the style it encourages. Even if try and synchronized blocks are blocks, I really prefer the way the current NetBeans formatter wraps them in an explicit block. So, I wonder if this is not the reason nobody hurried to include your patch. It really does feel like a matter of preference so perhaps it should be hidden behind some flag? --emi On Wed, Jan 18, 2017 at 1:30 AM, <[email protected]> wrote: > A while back I proposed a patch to an enhancement issue I created but > despite tagging, cc:ing, tweeting and emailing I haven't been able to > get any response at all on it. The Contributing Patches page, > https://netbeans.org/community/contribute/patches.html, is perhaps > incomplete? > > Anyway the issue is > https://netbeans.org/bugzilla/show_bug.cgi?id=269050. I am looking > forward to the Apache infrastructure where I issue a PR and presumably > get it in the right person's queue to consider it. > > Cheers, > > Mike >