Re: Verification of bug fixes

--047d7bb045c4874b0604e7c2b420
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Thank you, Jirka, your feedback helps me a lot!

On Wed, Oct 2, 2013 at 10:31 AM, Ji=C5=99=C3=AD Kovalsk=C3=BD <jiri.kovalsk=
[email protected]>wrote:

>
> No. For API changes and fixes in High Resistance mode code review is done=
.
> See for example here: https://netbeans.org/bugzilla/**
> show_bug.cgi?id=3D234353<https://netbeans.org/bugzilla/show_bug.cgi?id=3D=
234353>


That's interesting!
Can we say that all or most fixes in High Resistance mode have the keyword
*_HR_*, and all API changes have the keyword *API*?
If so, do you know since when the keywords are consistently used?

I'm asking because, in my research, I need to be able to tell what
happened, verification-wise, just by analyzing bug reports.

About code reviews, let me see if I understood correctly:

* the fix to be reviewed is always submitted as an attachment in the bug
report
* the bug is mark as FIXED only after it has been reviewed and committed to
the hg repo.

Is that right?

Also, do you recall any bug that was reopened because an automated test
>> case turned into red?
>>
>
> For example:
> https://netbeans.org/bugzilla/**show_bug.cgi?id=3D236010<https://netbeans=
.org/bugzilla/show_bug.cgi?id=3D236010>
> https://netbeans.org/bugzilla/**show_bug.cgi?id=3D235589<https://netbeans=
.org/bugzilla/show_bug.cgi?id=3D235589>


So these bugs were reported because a test failed, right?
This is what the TEST keyword means, right? (that's what
https://netbeans.org/bugzilla/describekeywords.cgi says)
Can we say that all or most bugs reported because of failing tests have the
TEST keyword?
Do you know since when is the TEST keyword consistently used?

The bug reports were marked as REOPENED because of failing tests; instead,
they were reported because of them. If a failing test can be linked to a
bad bug fix, what's the procedure? (a) the bug reported reopened, or (b) a
new bug report is created?


> Hope this helps,
> -Jirka
>

Absolutely!

[]s
Rodrigo

--047d7bb045c4874b0604e7c2b420
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Thank you, Jirka, your feedback helps me a lot!=C2=A0<div =
class=3D"gmail_extra"><br>On Wed, Oct 2, 2013 at 10:31 AM, Ji=C5=99=C3=AD K=
ovalsk=C3=BD <span dir=3D"ltr">&lt;<a href=3D"mailto:[email protected]=
om" target=3D"_blank">[email protected]</a>&gt;</span> wrote:<br>

<div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margi=
n:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204=
);border-left-style:solid;padding-left:1ex"><div class=3D"im">
<br></div>
No. For API changes and fixes in High Resistance mode code review is done. =
See for example here: <a href=3D"https://netbeans.org/bugzilla/show_bug.cgi=
?id=3D234353" target=3D"_blank">https://netbeans.org/bugzilla/<u></u>show_b=
ug.cgi?id=3D234353</a></blockquote>

<div><br></div><div style>That&#39;s interesting!=C2=A0</div><div style>Can=
 we say that all or most fixes in High Resistance mode have the keyword *_H=
R_*, and all API changes have the keyword *API*?=C2=A0</div><div style>If s=
o, do you know since when the keywords are consistently used?</div>

<div style><br></div><div style>I&#39;m asking because, in my research, I n=
eed to be able to tell what happened, verification-wise, just by analyzing =
bug reports.<br></div><div style><br></div><div style>About code reviews, l=
et me see if I understood correctly:</div>

<div style><br></div><div style>* the fix to be reviewed is always submitte=
d as an attachment in the bug report</div><div style>* the bug is mark as F=
IXED only after it has been reviewed and committed to the hg repo.</div>

<div style><br></div><div style>Is that right?</div><div style><br></div><b=
lockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-le=
ft-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;pad=
ding-left:1ex">

<div class=3D"im"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px=
 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-=
left-style:solid;padding-left:1ex">Also, do you recall any bug that was reo=
pened because an automated test<br>


case turned into red?<br>
</blockquote>
<br></div>
For example:<br>
<a href=3D"https://netbeans.org/bugzilla/show_bug.cgi?id=3D236010" target=
=3D"_blank">https://netbeans.org/bugzilla/<u></u>show_bug.cgi?id=3D236010</=
a><br>
<a href=3D"https://netbeans.org/bugzilla/show_bug.cgi?id=3D235589" target=
=3D"_blank">https://netbeans.org/bugzilla/<u></u>show_bug.cgi?id=3D235589</=
a></blockquote><div><br></div><div style>So these bugs were reported becaus=
e a test failed, right?</div>

<div style>This is what the TEST keyword means, right? (that&#39;s what=C2=
=A0<a href=3D"https://netbeans.org/bugzilla/describekeywords.cgi">https://n=
etbeans.org/bugzilla/describekeywords.cgi</a>=C2=A0says)<br></div><div styl=
e>Can we say that all or most bugs reported because of failing tests have t=
he TEST keyword?</div>

<div style>Do you know since when is the TEST keyword consistently used?</d=
iv><div style><br></div><div style>The bug reports were marked as REOPENED =
because of failing tests; instead, they were reported because of them. If a=
 failing test can be linked to a bad bug fix, what&#39;s the procedure? (a)=
 the bug reported reopened, or (b) a new bug report is created?</div>

<div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px =
0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-l=
eft-style:solid;padding-left:1ex">
Hope this helps,<br>
-Jirka<br></blockquote><div><br></div><div style>Absolutely!</div><div></di=
v></div><br></div><div class=3D"gmail_extra" style>[]s</div><div class=3D"g=
mail_extra" style>Rodrigo</div></div>

--047d7bb045c4874b0604e7c2b420--