Re: [tasklist] one click fixing

On Sun, 2003-03-09 at 21:55, andrew wrote:
> A little suggestion is: one click fixing. Now I must:
> 
> - select all fixable suggestions
> - click "Fix..." icon
> - confirm fixing all with clicking "Fix All" button
> 
> I'd want:
> 
> - click (new) icon at the left panel to fix all fixables without
>   confirming ("Force fix" without ellipsis :-)
> 
> I see, this way may be dangerous. A little dialog "Are you sure... ?"
> with "show next time" checkbox may appear.
> 
> Is anybody agree with me, such way is handy?

Well, having written the fixer operators I'd prefer it if you
visually inspect what it's going to do first .... the javaparser
module despite its name does not have any semantic understanding
of the source code, it simply operates with heuristics on source
lines. For example, to insert a cast, it takes the column position
reported by the compiler for the error, backtracks until it finds
a non-identifier character, and inserts '('+targetClass+')'...

There already is a "Fix..." button in the suggestions window toolbar,
and it provides a toolbar - if you click "Fix All" this is the
same number of mouse clicks as you suggested above (2 clicks -
one on the action, one on a confirmation dialog, here "Fix All"
instead of "Yes I'm sure").   It sounds like you're asking for
a "Fix" button instead of "Fix..." (one which bypasses normal
confirmation).  I'm reluctant to add that to a visible view.
However, we can add it to the actions pool. Once the toolbars become
customizable (there's an issue filed for that), you can add it to
the toolbar yourself.

Does that sound reasonable?

-- Tor

P.S. I haven't been able to use the compiler module yet (I haven't
been online since Tim made his last commit) so I haven't checked to
see if he's using the same toolbar as the suggestions view (which
it seems to me like it would be a good thing.)