Re: [tasklist] compiler module feedback
"Tim Lebedkov" <[email protected]>
| Newsgroups | gmane.comp.java.netbeans.modules.tasklist.devel |
|---|---|
| Message-ID | <006b01c2e96d$39085670$7a14b9ac@timpc> |
Hi Tor, ----- Original Message ----- From: "Tor Norbye" <[email protected]> To: <[email protected]> Sent: Tuesday, March 11, 2003 3:23 PM Subject: Re: [tasklist] compiler module feedback > On Tue, 2003-03-11 at 02:03, Tim Lebedkov wrote: > > > Anyway, Jesse Glick reads this newsgroup now and then, and I'm > > > pretty sure he wrote the ant integration module (or at least has > > > done some work on it) so he may have ideas for how this could be > > > done. Perhaps we'll need a third integration module, one which > > > hooks into the ant module's apis for replacing its output API > > > calls... > > > > What about the TL API enhancements? > > I'm sorry -- what are you referring to here? We need a public API for OutputTab replacement. the API could be very simple: public class ProcessMessage { CompileTask currently has following attributes: -severity -line -column -FileObject -priority??? (or maybe is severity enough?) -type -summary -details -suggestions??? (or maybe SystemAction[] getActions()) Annotation createAnnotation(); } public class ProcessMessageView { public static ProcessMessageView create(String name); public void add(ProcessMessage msg); public void clear(); public void setVisible(boolean v); } Two things are not clear to me now: - whether the attributes of ProcessMessage would satisfy all future needs. - would anybody use this API if it depends on TL/core? > Couldn't you simply aggregate strings from multiple lines? It looks as > though new errors are the lines that have an associated Line object. > > Yes, I know it's not very clean, but then the compiler module is already > having to do some hacks since it's replacing the IDE compilation > service, masking some menu items, etc. > I commited a README file http://tasklist.netbeans.org/source/browse/tasklist/compiler/src/org/netbean s/modules/tasklist/compiler/ with instructions how to improve error parsing > Ok. But: (WARNING - the below is nitpicking) > > * I'd prefer it if these error-views stayed consistent. There already is > an error icon that's used "everywhere" in the UI. > * These icons look more polished than some of the NetBeans icons. > Did you draw them? If so, great job - and can you please take a stab > at fixing some of our other icons too, in particular the PMD one? > If not, have you made sure we have permission to use these icons? > (They're not from a product, or from a tool using a GPL license, > right?) Unfortunately, icons are treated in much the same way as > other external downloads - their license has to be reviewed etc. There was no license in the zip file I downloaded from kde-look.org (Aqua icons for KDE 3.1) so I assumed it is freeware. I will ask the author whether the icons are under GPL. > * Have you tried using .gif instead of .png? I noticed that the icons > looked great from Mozilla, but in the treetableview, the corners are > a bit sharp. I think I remember discovering before that > alpha/translucency is not handled well for .png's on some systems. The problem is that TreeTableView does not use antialiasing. You can see it if you select a png file in the NB explorer and look at the properties of this file. On Windows properties view uses antialiasing. Tim