Re: [ANN] TODOs in standard build

Petr Kuzel a écrit :

> Vincent Brabant wrote:
> 
> 
>>Hereafter summary of my complaints:
>>1. icons have no tooltips. So, impossible to know their usage by letting
>>the mouse cursor on. 2. by default it does that for all mounted
>>filesystems. After one hour, it was not yet finished (I had only the
>>netbeans source). I tried to click on the stop button, but the result was
>>the button disappear, and no more possible to click on it. 
> 
> 
> You can change the scope default to project by setting system property
> -J-Dtodos.project=project. 
Ahah. A hidden feature. Maybe better to add it in the Tools | Options panel.

> You can also restructure your mounts
> and mount sources for files you work on and binaries for libraries.
Just some others questions. How to say to scan only java files and not html or jsp one for example.
I have impression that it scanned also html file presents in mounted javadoc filesystems. Am i Wrong ?

> I plan to optimize scannig later on, mainly pushing on java
> EditorCookie provider.
> 
> 
>>3. sometimes
>>the title of columns dissapear, or to be more exact are displayed in a one
>>pixel height (so you can't read the title) 
>>4. Sometimes column titled
>>suggestion has no more title.
>>5. In the Change Visible Columns, the first
>>column has no title.
> 
> 
> I saw it few times too. I guess that it's TreeTableView issue.

I am not sure that renaming the column name is a TreeTableView issue.
And I have not yet remarked that behaviour in another context than the TaskList one.
> 
> 
>>6. In the tools | Options, you can only change string
>>to search for, but not add or remove them. Buttons are disabled. 
> 
> 
> UI not yet fully specified, TBD.
Ok.
> 
> 
>>7. It's
>>always running and Impossible to work with it anymore. I will kill the
>>application :-(( 
> 
> 
> Details here, please.

I did a reference to point 2. When I started netBeans, I had in my filesystems all the sources of the netbeans project.
The first time I clicked on the /** icon, it begin to scan all mounted filesystems. When I begin to write the mail, it was one hour later. When I begin to write point 7, another 15 minutes elapsed.
> 
> 
>>8. It seems that sometimes it displays message in the
>>message line of the netbeans ide. Sometimes aside the three icones. The
>>All files tab was enabled and message displayed aside the three icons. I
>>clicked on the Current File tab and the message was then displayed in the
>>message line, at the bottom of the main windows.
> 
> 
> In my opinion it's writing to main status bar excessively.
> I prune it back.
> 
> 
>>9. Filters are not IMHO
>>sufficient : You can't create filter depending on priority or filter
>>depending on place where Strings are found (in COMMENT or NOT in COMMENT).
> 
> 
> The priority filter is ommission. The context filter is possible
> enhancement for future version.
Maybe also add a filter for filesystems. Means that I can see ressults concerning a particular filesystem only.
> 
> 
>>10. Icons have nice colors. 11. I never succes to use netbeans after
>>launching the TODO window. So, for me, it failed.
>>12. I prefered the old way where I could choose the directory and ask to
>>scan for that directory. I really found stupid the approach to have only
>>choice between Parse All Filesystems  or parse just the current file. 13.
> 
> 
> We was not able to invent UI for Scanned TODOs that would be
> consistent with All Files and Current File inner tabs. At maximum
> one outer tab is allowed for one kind of tool window according
> to new window system guidelines.

Ok, but maybe another approach would be possible:
I choose a node in filesystems (lets for example the ant/src of netbeans), click on /** icon, it put results in the tables.
I choose another node (lets for example the core/compile/src of netbeans), click on /** icon, it concatenate results in the same table.
And I can do filtering on packages (that already exists by create a filter with filename as criteria), filesystems, ...
> 
> 
>>I finally receive a lot of Parser Error: Out of Memory Exception. And
>>Impossible to stop it, except by killing NetBeans. *********** Exception
>>occurred ************ at Wed Dec 17 03:44:23 CET 2003 Annotation: Parser
>>error
>>[catch]java.lang.OutOfMemoryError
>>==>
>>WARNING - ErrorManager detected cyclic exception nesting:
>>        java.lang.OutOfMemoryError
>>Be sure not to annotate an exception with itself, directly or indirectly.
> 
> 
> I hope that impossibility to stop is given by window system bug that
> consumes mouse events. So you have to click twice on the Stop button
> (should be fixed now) or press ESC key. 
I am not sure it's a window system bug.
> 
> 
>>14. Each time I select Window TODOs, system open a new TODO window and
>>restart parsing on all filesystems in place of displaying the existing TO
> 
> 
> It's bug.
> 
> 
>>DO window. Before it has normal that it opened a new TODO window because
>>you can have a TODO window for each filesystems for example. But now, you
>>have all or nothing, so it's totally stupid to open a totally new window
>>and restart parsing on all filesystems. 15. It must clearly be improved. I
>>begin to regret to old implementation.
> 
> 
> Just curious, have you scanned the same scope (whole repository)?
Before, with 3.5.1 I choosed the main repository of the module I worked on. Example: ant/src
And asked to give me all suggestions.
Now, I just open a file, clicked on the /** icon. And it begins to scan all mounted filesystems.

I prefered that it scan only the visible file in first priority, then all opened file in second priority, and then, but not as default, only on demand, all mounted filesystems, but the one you are busy as third priority.

Summary:

When I click on the /** button:

It scans the file I am busy to work on it
It pauses to be sure that result can be displayed and display the TODO window with "current file" tab displayed.
If I click on the All file tab, 
then, 
	It scans all other files opened in the editor
	It pauses to be sure that result can be displayed.
	It scans all other files belonging to the same filesystem than the one I am currently editing 
	It scans all other files belonging to other filesystems, giving priority to filesystems of already opened files.

Add somes column like filesystem name, package name (could be hidden by default, but are there to permits us to create filters on those column).

P.S. May I introduce one issue with all that stuff (easier for me), or do you prefer many little issues (easier for you)

> 
>   Cc.
> 


-- 
Vincent Brabant
----------------
http://www.netbeans.org/index_fr.html
http://vbrabant-fr.skynetblogs.be