Re: [ANN] TODOs in standard build

Petr Kuzel a écrit :

> Hi Vincent,
> 
> thanks for feedback. I'm confident you'll find some hope in my reply.
> 
> Vincent Brabant wrote:
> 
> 
>>>>9. Filters are not IMHO
>>>>sufficient : You can't create filter depending on priority or filter
>>>>depending on place where Strings are found (in COMMENT or NOT in
>>>>COMMENT).
>>>
>>>The priority filter is ommission. The context filter is possible
>>>enhancement for future version.
>>
>>Maybe also add a filter for filesystems. Means that I can see ressults
>>concerning a particular filesystem only.
> 
> 
> FS concept as whole is problematic. It'll be replaced
> by some more user friendlier one later on.

Could you give more details about that ? I am interrested.
> 
> 
>>>>10. Icons have nice colors. 11. I never succes to use netbeans after
>>>>launching the TODO window. So, for me, it failed.
>>>>12. I prefered the old way where I could choose the directory and ask to
>>>>scan for that directory. I really found stupid the approach to have only
>>>>choice between Parse All Filesystems  or parse just the current file. 13.
>>>
>>>
>>>We was not able to invent UI for Scanned TODOs that would be
>>>consistent with All Files and Current File inner tabs. At maximum
>>>one outer tab is allowed for one kind of tool window according
>>>to new window system guidelines.
>>
>>Ok, but maybe another approach would be possible:
>>I choose a node in filesystems (lets for example the ant/src of netbeans),
>>click on /** icon, it put results in the tables. I choose another node
>>(lets for example the core/compile/src of netbeans), click on /** icon, it
>>concatenate results in the same table. And I can do filtering on packages
>>(that already exists by create a filter with filename as criteria),
>>filesystems, ...
> 
> 
> :-). It clashes with another guideline that calls for
> elimination of context sensitive actions in global toolbar and menu.
> If you click global TODOs you want global/project TODOs.

I am not sure to well understand.
When I select a node in FS and click on the debug icon, it's just debug that class.
When I select a node in FS and click on the commit icon, it's just commiting that file(s).
When I select a node in FS and click on the Tools Junit Test Create Test Class, it create junit test class only for that node.

So, it seems normal that when I select a node in FS and click on the todo icon, it's just launching todo for that file.

Am I misunderstand what you said ?


> 
> 
>>>Just curious, have you scanned the same scope (whole repository)?
>>
>>Before, with 3.5.1 I choosed the main repository of the module I worked
>>on. Example: ant/src And asked to give me all suggestions.
>>Now, I just open a file, clicked on the /** icon. And it begins to scan
>>all mounted filesystems.
>>
>>I prefered that it scan only the visible file in first priority, then all
>>opened file in second priority, and then, but not as default, only on
>>demand, all mounted filesystems, but the one you are busy as third
>>priority.
> 
> 
> It's your personal preference. You can almost satisfy it with
> current design (well some impl bugs need to be fixed). Others
> want primary TODOs for whole project (look at supported scenarios).

So, if scenarios is to have all file by default, I have nothing to say, even if I disagree.
But, even if it's ALL file by default, 
you can begin to scan the current open file, then all other open file, then all other files of the current filesystems, then all other filesystems.
Then, if I click on STOP after 1 minute, I have at least data concerning opened files, and no data concerning a filesystem I don't care at this moment.

>  
> 
>>Summary:
>>
>>When I click on the /** button:
>>
>>It scans the file I am busy to work on it
>>It pauses to be sure that result can be displayed and display the TODO
>>window with "current file" tab displayed. If I click on the All file tab,
>>then,
>>It scans all other files opened in the editor
>>It pauses to be sure that result can be displayed.
>>It scans all other files belonging to the same filesystem than the one I
>>am currently editing It scans all other files belonging to other
>>filesystems, giving priority to filesystems of already opened files.
> 
> 
> It can be driven by two global options:
>   - Default TODOs:   All Files (default) or Current File 
>   - All Files means: Repository (default), Project or all opened files
> 
> Then you would just customize these options.... Dusan what
> do you think? It's not implementation problem so I'm willing
> to implement it till feature freeze.
It would be nice to have also those options. Sure
> 
> 
>>Add somes column like filesystem name, package name (could be hidden by
>>default, but are there to permits us to create filters on those column).
>>
>>P.S. May I introduce one issue with all that stuff (easier for me), or do
>>you prefer many little issues (easier for you)
> 
> 
> A summary issue for issues that represents your point of view on UI
> (and defaults). Separate issues for UI spec implementation bugs.
> 
>   Cc.
> 
OK. I will certainly do that this week.

Thanks a lot.

BTW, I just constated that in the 20031217 the /** icon has been replaced by another one. But difficult to understant the meaning of the new one. (But it's true that old one /** was confusing because by default it search String everywhere, not only in comments)
Also constated that when I double click on the /** icon, it's not open a new tab and relaunching the scan.
So, congratulation therefore. Good job.

-- 
Vincent Brabant
----------------
http://www.netbeans.org/index_fr.html
http://vbrabant-fr.skynetblogs.be