Re: Features brainstorming

Petr Kuzel a écrit :
> Vincent Brabant wrote:
> 
> 
>>Petr Kuzel a écrit :
>>
>>
>>>[...]
>>>Background: some needs PMD presence (an extra parser) others
>>>can be derived from exiting results of background processing
>>>(java/srcmodel or mdr). I think that existing PMD suggestions
>>>should be reimplemented over existing parser results to
>>>get reasonable performance.
>>>[...]
>>
>>You have to see PMD as standard tool for Suggestion, like Ant is standard
>>tool for Build. Because each developper can easily build his own set of
>>rules for PMD, like developper can build his own tasks,
>>it's important that tasklist module continue to support PMD.
> 
> 
> PMD is not only way for identifying possible problems.
> Found problems are paired with solution (java code in tasklist/pmd)
> to form a suggestion. Custom rules miss the solution part (subject of planned PMD enhancements).
> 
> Also compare currently provided solutions from user's point of view:
>   - delete unused variable (PMD)
>   - delete unused import (PMD)
>   - add import (javaparser)
>   - create method (javaparser)
>   - type cast (javaparser)
>   - identifier case errors (javaparser)
> you can see that most common suggestions come from non-PMD provider in spite of fact it could be provided by PMD. 
> Simply actual implementation is irrelevant for most users. We need
> to identify crucial suggestions and provide their fast implementation.
> 
> I'd say that raw PMD support (covering custom queries) should be addressed by PMD integration module rather than tasklist.
> 
>   What do you think?

I think that if you are doing that, you will break what has been the success of tasklist module until now.


>   Cc.
> 
> PS: What custom PMD queries do you use?

We have custom PMD queries to check that all our package are following our standard (com.ourcompany.ourdomain.ourservice)
And also some PMD queries that check that we are not using System.out.println or System.err.println on our source code.
And also some PMD queries that check that each catch put a trace in the log file.
And also a PMD query that check that we import well our logging class in all our projects.

-- 
Vincent Brabant
----------------
http://www.netbeans.org/index_fr.html
http://vbrabant-fr.skynetblogs.be