HR fix 151364 Weird error when compiling
Thomas Preisler <[email protected]>
| Newsgroups | gmane.comp.java.netbeans.reviewers |
|---|---|
| Message-ID | <[email protected]> |
Description of the bug: 151364 Weird error when compiling http://www.netbeans.org/issues/show_bug.cgi?id=151364 Open Add Preprocessor Definition dialog to enter a macro definition and click either 1) Cancel or 2) OK without typing something in the text field will cause uncompilable code (empty -D option) to be generated. The project will not build. 1) is a common scenario. Impact assessment: If the user opens the Add Preprocessor Definition dialog and jut clicks Cancel, incorrect makefile will get generated and his project is uncompilable. It is not an uncommon scenario and it is not obvious to understand what happened and how to correct the error. Risk assessment i.e. why is it safe?: Checking for empty string and checking for null. Simple, isolated, and low-risk changes. Confirmation of peer code review and QE verification of fix: Code change reviewd and approved by Gordon Prieur. See bug report. Fix validated by Alexander Pepin (QA). See bug report. Changeset info (for reviewing diffs): Changeset: http://hg.netbeans.org/main/rev/9f4c9b164136 User: Thomas Preisler <[email protected]> Log: #151364 Weird error when compiling