Re: Please review fix for #151944

I think there is a problem with the use of Parameters.notNull() in 
JDBCDriverDeployHelper.getMissingDrivers()

This call can generate an NPE, which is going to bubble out to callers....

I think it would be better to log the situation and return an empty 
list... or change this:

                File driverLoc = driverLocs[j];
                Parameters.notNull("driverLoc", driverLoc);
                if (driverLoc.exists()) {

TO

                File driverLoc = driverLocs[j];
                if (null != null && driverLoc.exists()) {

vbk


Nitya Doraisamy wrote:
> Please review the fix for
> http://www.netbeans.org/issues/show_bug.cgi?id=151944
>
> Fixed & verified in main : Changeset: 
> http://hg.netbeans.org/main/rev/b09c3560b3fc
>
>
> Problem:
> Deployment to GlassFish v3 fails if JDBC Driver deployment is enabled.
> Invalid parameter is being passed resulting in NPE. Feature
>
> Justification: Target feature is broken
> Solution:
> Pass the correct parameter representing V3 root location and add check 
> to validate
> parameters.
>
> -Nitya
>