#176899 HR Fix
Jaroslav Bachorik <[email protected]>
| Newsgroups | gmane.comp.java.netbeans.reviewers |
|---|---|
| Organization | Sun, Inc. |
| Message-ID | <1258380620.7137.34.camel@bender> |
Description: #176889 - JavaFX Refactoring functionality is disabled for 6.8 by default Refactoring functionality has been disabled for 6.8 beta but needs to be enabled for 6.8 Impact assessment: Not fixing this issue will cause complete loss of refactoring functionality for JavaFX in NB6.8 Risk assessment: The fix consists of removing the condition guarding the factory methods providing JavaFX specific refactoring plugins. The fix is completely safe and with no side effects. Peer review is attached. Changeset info: http://hg.netbeans.org/javafx/rev/cd08a14708fe -- Jaroslav Bachorik <mailto: [email protected]> NetBeans IDE http://www.netbeans.org Senior Software Engineer Sun Microsystems, Prague, Czech Republic
peer_review.txt
(text/plain, 1.7 KB)
From [email protected] Mon Nov 16 14:07:15 2009 Return-path: <[email protected]> Received: from fe-emea-09.sun.com ([unknown] [192.18.6.119]) by emea4-mail1.uk.sun.com (Sun Java(tm) System Messaging Server 7u2-7.04 64bit (built Jul 2 2009)) with ESMTP id <[email protected]> for [email protected]; Mon, 16 Nov 2009 14:07:15 +0000 (GMT) Original-recipient: rfc822;[email protected] Received: from conversion-daemon.fe-emea-09.sun.com by fe-emea-09.sun.com (Sun Java(tm) System Messaging Server 7u2-7.04 64bit (built Jul 2 2009)) id <[email protected]> for [email protected] (ORCPT [email protected]); Mon, 16 Nov 2009 14:07:15 +0000 (GMT) Received: from [129.157.20.135] ([unknown] [129.157.20.135]) by fe-emea-09.sun.com (Sun Java(tm) System Messaging Server 7u2-7.04 64bit (built Jul 2 2009)) with ESMTPSA id <[email protected]> for [email protected] (ORCPT [email protected]); Mon, 16 Nov 2009 14:07:00 +0000 (GMT) Date: Mon, 16 Nov 2009 15:09:15 +0100 From: Karol Harezlak <[email protected]> Subject: Re: Can you review this changeset? In-reply-to: <1258380006.7137.23.camel@bender> Sender: [email protected] To: [email protected] Message-id: <[email protected]> MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=UTF-8 References: <1258380006.7137.23.camel@bender> User-Agent: Thunderbird 2.0.0.23 (X11/20090817) X-Evolution-Source: imap://[email protected]/ Content-Transfer-Encoding: 8bit Ok done, reviewed. Karol Jaroslav Bachorik wrote: > http://hg.netbeans.org/javafx/rev/cd08a14708fe > > I need it for HR FIX process.... > > Thanx > > JB > >