Review of a fix for the issue #172663
Alex Petrov <[email protected]>
| Newsgroups | gmane.comp.java.netbeans.reviewers |
|---|---|
| Message-ID | <[email protected]> |
A review of a fix for the issue #172663 * Description of the bug #172663 (http://netbeans.org/bugzilla/show_bug.cgi?id=172663) AssertionError at org.netbeans.modules.xml.xdm.diff.MergeDiff.applyChildrenDiffs. * Impact assessment i.e. why it is a showstopper? This issue has more than 50 duplicates. * Risk assessment i.e. why is it safe? This issue was caused by an accident coincidence of IDs of 2 nodes in XDM model, related to an edited XML document. For example, when an user edits the file "faces-config.xml", sometimes the ID of the node "Comment", included into the node "Document", is equal to the ID of a node "Text", typed inside the root element "<faces-config>". Unique ID for each XDM model node will prevent from a such conflict. * Confirmation of peer code review and QE verification of fix * Changeset info (for reviewing diffs) http://hg.netbeans.org/main/rev/eb9e210ddb70 Thanks. Alex Petrov ([email protected])