Please review the fix for the issue #186372 - IllegalArgumentException: URI is not hierarchical
Vladimir Kvashin <[email protected]>
| Newsgroups | gmane.comp.java.netbeans.reviewers |
|---|---|
| Message-ID | <[email protected]> |
Hi, Please review the fix for the issue #186372 - IllegalArgumentException: URI is not hierarchical Description of the bug When adding a remote host, exception occurs. The bugzilla issue is http://netbeans.org/bugzilla/show_bug.cgi?id=186372 Impact assessment The issue does not allow user to set up a remote host, i.e. does not allow using remote development feature at all. Risk assessment The fix is easy, it doesn't involve lots of code. Just in case an exception is thrown from one of the calls in the fix code, the fix code is embedded into try/catch, and if a runtime exception occurs, it is just logged and the provider is disabled. The entire IDE and remote feature continues working, just one of source lines info providers is disabled. So in this respect the code is safer than before fix - it can't break host setup in any case. There are several unit tests that involve this code, so the fix is verified on all platforms. Confirmation The fix (source code) is reviewed by Alexander Simon. The fix is verified and reviewed by QA using bits built on bertram server from cnd-main Changeset info http://hg.netbeans.org/cnd-main/rev/ac631403affb Thank you, Vladimir