NB 7.0 HR review for "Incorrect error badges on Maven 3 sources" bug

Jan Lahoda <[email protected]> Wed, 16 Mar 2011 14:24:38 +0100
Newsgroups gmane.comp.java.netbeans.reviewers
Message-ID <[email protected]>
Bug IDs:
http://netbeans.org/bugzilla/show_bug.cgi?id=188323
http://netbeans.org/bugzilla/show_bug.cgi?id=196554

Description:
Maven projects commonly download libraries from the internet and 
generate sources during build. Sometimes the IDE shows incorrect error 
badges for some files after build is done and libraries are downloaded. 
These are partially caused by several bugs in the Java infrastructure.

Impact:
Incorrect error badges on some files destroys user's confidence in the 
IDE and may cause other features, like compile on save, to misbehave.

Risks:
There are three total changes:
http://hg.netbeans.org/jet-main/rev/ae47803540da
which ensures that errors are correctly assigned to files during 
scanning. This should be very safe. Reviewed by dbalek.

http://hg.netbeans.org/main/rev/49d13ed75da4
which ensures that compilation of dependencies is always done in the 
dependency order. Low risk. Reviewed by tzezula.

http://hg.netbeans.org/jet-main/rev/8e4cf2406610
which only integrates this change in nb-javac:
http://hg.netbeans.org/main/nb-javac/rev/a0140acb2b3d
which partially reverts one of our patches that originally ensured that 
false errors are not reported for elements created during annotation 
processing. As javac proper currently contains solution of this problem, 
the patch is likely unneeded. Tests that tested the original problem 
pass. Reviewed by dbalek.

juhrik verified the changes.

Thanks,
     Jan