Review 70_HR_FIX_CANDIDATE

Alexander Simon - Oracle - St Petersburg Russia <[email protected]> Wed, 16 Mar 2011 18:14:57 +0300
Newsgroups gmane.comp.java.netbeans.reviewers
Message-ID <[email protected]>
Bug 196378 - Makefile-variables.mk:1: warning: NUL character seen; rest 
of line ignored
(http://netbeans.org/bugzilla/show_bug.cgi?id=196378)
CND creates makefile that cannot be made on remote host in case latest 
Linux distribution.
Root causes of bug:
- makefile touches sub-makefile by mistake.
- CND uses java.io for creating sub-makefile. It makes not synchronized 
FO and disk file.
Remote file system in this case does not upload real sub-makefile.
Fix consist from two part:
- use "FO create data" instead java.io
- fix priority of shell command in makefile .PHONY target.
Fix was reviewed by Vladimir Voskresensky.
Change sets:
http://hg.netbeans.org/cnd-main/rev/90ad19c76115
http://hg.netbeans.org/cnd-main/rev/c86be8b62a57
http://hg.netbeans.org/cnd-main/rev/2d7be6463d34
http://hg.netbeans.org/cnd-main/rev/918e585ae30d