fixing 196748 profiler is not on if run with arguments in release70
Thomas Preisler <[email protected]> Mon, 21 Mar 2011 11:21:27 -0700
| Newsgroups | gmane.comp.java.netbeans.reviewers |
|---|---|
| Message-ID | <[email protected]> |
Description of the bug (including IZ #) 196748 profiler is not on if run with arguments CND profiler is not on if project is run with arguments. Impact assessment i.e. why it is a showstopper? CND profiler is a core feature of CND/C++ projetcs and it gets disabled just by adding run arguments to the project which is very common to do. Risk assessment i.e. why is it safe? Very low. Old code erroneously just checked command for presence of a space and then assumed then run command was 'complex' and turned profile off. Replaced the check with a slight more complicated check that only turns profile off if not the default command or not a library project. Safe in-function string manipulations. Confirmation of peer code review and QE verification of fix Code reviewed by Igor Nikiforov and algorithm also by Andrew Krasny. Changeset info (for reviewing diffs) changeset: 195149:4b9db51d04ab branch: release70 tag: tip parent: 195138:c305d435060c user: Thomas Preisler <[email protected]> date: Mon Mar 21 11:00:55 2011 -0700 summary: #196748 profiler is not on if run with arguments Please note: I accidentally pushed the changeset to release70 before the timeout.