Review of #193228 - [70cat] Wrong error highlighting for EL condition in attribute

Marek Fukala <[email protected]> Thu, 24 Mar 2011 14:31:52 +0100
Newsgroups gmane.comp.java.netbeans.reviewers
Message-ID <[email protected]>
Hi all,

I'd like to ask for the review of the issue 193228 - [70cat] Wrong error 
highlighting for EL condition in attribute

issue: http://netbeans.org/bugzilla/show_bug.cgi?id=193228

fix: http://hg.netbeans.org/web-main/rev/2ee2f2648878


Description: Errors are shown and editor features doesn't work for EL 
expressions in xhtml facelet files with xml entity references.

Impact: False errors flagged in the code, user cannot use completion, 
refactoring on such expressions etc.

Fix: Created an EL preprocessor which replaces the entity references by 
the referred chars and allows to remap the positions from the 
preprocessed code and back.

Risk: Medium, the fix is not trivial. Needs to be tested thoroughly.

Thanks,
Marek