#197538 - Entity annotation not separated by a new line
Jan Lahoda <[email protected]> Tue, 22 Nov 2011 11:32:35 +0100
| Newsgroups | gmane.comp.java.netbeans.reviewers |
|---|---|
| Message-ID | <[email protected]> |
Bug:
http://netbeans.org/bugzilla/show_bug.cgi?id=197538
Description: When an Entity class is created using the wizard, a newline
may be missing between the "@Entity" annotation and the public modifier
of the class, leading to uncompilable code. The problem appears when a
single character needs to be copied from the original file to the new
file, and the original file contains '\r' at that position. As '\r' are
ignored, another character needs to be fetched from the file, but
incorrectly wasn't.
Impact assessment: incorrectly uncompilable class after using a wizard.
Risk assessment: the patch should affect only this specific situation
and so should not cause problems in unrelated cases.
The fix has been verified by jskrivanek and reviewed by tzezula.
Fix:
http://hg.netbeans.org/jet-main/rev/6bc3b68f72f3
Thanks for the review,
Jan