NB 7.2 HR integration review request: #214181 - OrganizeImports run through Source/Inspect parses the source code again

Jan Lahoda <[email protected]> Mon, 18 Jun 2012 22:21:05 +0200
Newsgroups gmane.comp.java.netbeans.reviewers
Message-ID <[email protected]>
Description:
http://netbeans.org/bugzilla/show_bug.cgi?id=214181

When OrganizeImports is run inside Sour/Inspect..., each source code is 
parsed twice, leading to unnecessarily slow progress. The fix is to add 
the Parser that was used by parsing.api to parse the current file into 
the overlay temporary SourceCache created for the file.

Impact assessment: any configuration in Source/Inspect... that includes 
OrganizeImports is unnecessarily significantly slower.

Risk assessment: risk is low - there already is a temporary SourceCache 
created for each file in multi-source tasks, the fix only ensures that 
the parser used by the infrastructure to parse the file is set to the 
SourceCache.

The fix has been reviewed by Tomas Zezula and verified by Jiri Prox.

Changeset:
http://hg.netbeans.org/main-silver/rev/fcfcbf3370f4

Thanks for the review,
    Jan