Re: NB7.2 HR Fix: #214374 - Font in searchpanel has not anti aliasing

Miloslav Metelka <[email protected]> Fri, 22 Jun 2012 18:24:16 +0200
Newsgroups gmane.comp.java.netbeans.reviewers
Message-ID <[email protected]>
Tim,
  what particular instance of a text field do you mean, the one in 
search bar? IIRC that one should be assigned with a font for text field.
  if pane.putClientProperty("AsTextField", true) is done the view 
hierarchy now does not pick a font from editor settings. The font is 
left on its default. Since BaseTextUI has

     protected String getPropertyPrefix() {
         return "EditorPane"; //NOI18N
     }

then it picks that constant from UIManager. It's compatible with 
BasicEditorPaneUI which uses the same constant.
IMHO I would not prefer doing 
pane.setFont(UIManager.getFont("TextField")) in a view hierarchy's code 
where the "AsTextField" property only serves as a way how to influence 
the VH's behavior. I would prefer putting a textComponent.setFont() into 
a utility method.
-Mila


On 06/22/2012 04:52 PM, Tim Boudreau wrote:
> Noticing in a daily build from yesterday, that it is also now using a 
> serif font - probably you want UIManager.getFont("control")
>
> -Tim
>
> On Fri, Jun 22, 2012 at 10:03 AM, Miloslav Metelka 
> <[email protected] <mailto:[email protected]>> wrote:
>
>     Description:
>     http://netbeans.org/bugzilla/ show_bug.cgi?id=214374
>     <http://netbeans.org/bugzilla/show_bug.cgi?id=214374>
>
>     Text in "Find" field in search bar (and in other places with
>     editor's kit implementations like Create Watch etc.) was not
>     antialiased.
>
>     Impact assessment: since search bar is frequently used this was a
>     highly visible problem (regression).
>
>     Risk assessment: low. The fix only restores proper setting of
>     renderingHints variable.
>
>     The fix has been reviewed by Milutin Kristofic and it should be
>     verified by QE.
>
>     Changesets:
>
>     http://hg.netbeans.org/jet- main/rev/0c7529097a87
>     <http://hg.netbeans.org/jet-main/rev/0c7529097a87>
>     http://hg.netbeans.org/jet- main/rev/0bf2406a227a
>     <http://hg.netbeans.org/jet-main/rev/0bf2406a227a>
>
>
>     Thanks for review,
>     -Mila
>
>
>
>
> -- 
> http://timboudreau.com
>