HR fix review: #214647 - Reproducible deadlock oracle.cloud vs. non-native keyrings?
David Konecny <[email protected]> Tue, 26 Jun 2012 10:55:00 +1200
| Newsgroups | gmane.comp.java.netbeans.reviewers |
|---|---|
| Message-ID | <[email protected]> |
Description: http://netbeans.org/bugzilla/show_bug.cgi?id=214647 Deadlock happens when native keyring is not available and user is using Oracle Cloud server. Impact assessment: I do not know how many users do not have "native keyring" in their OS but combination of that and usage or Oracle Cloud which stores credentials in key ring can deadlock the IDE during startup. In Martin's case deadlock happened during each IDE startup. Risk assessment: Fix is safe - all it does is it delays accessing key ring information which previously were unnecessarily read too early. Consequently that avoids deadlock from happening during IDE startup. Reviewed and tested by Martin Fousek. QA verification is going to happen soon. Changeset: http://hg.netbeans.org/web-main/rev/3892095d33f7 Thanks for the review, -David