HR integration review request: #214721 - [72cat] Matisse generates wrong code for JTable
Jan Lahoda <[email protected]> Tue, 26 Jun 2012 10:38:34 +0200
| Newsgroups | gmane.comp.java.netbeans.reviewers |
|---|---|
| Message-ID | <[email protected]> |
Description: http://netbeans.org/bugzilla/show_bug.cgi?id=214721 An anonymous innerclass constructor is generated to the source code when importing FQNs for form editor. Fixed by not performing importFQNs on the synthetic constructor, which made the code generator believe it should un-synthetize it. Impact assessment: Incorrect and incorrectly uncompilable code produced by the IDE by using the form editor, can break existing forms when regenerated. Risk assessment: very low risk - skipping synthetic constructors when performing importFQNs should not cause any problems. Reviewed by Tomas Zezula. QA verification by [email protected]. Changeset: in trunk: http://hg.netbeans.org/jet-main/rev/6a16d8fc7461 won't apply cleanly to release72, patch for release72: http://netbeans.org/bugzilla/attachment.cgi?id=121312&action=diff Thanks for review, Jan