HR integration review request: #223912 - Enabling on save actions breaks Refactoring
Jan Lahoda <[email protected]> Mon, 14 Jan 2013 13:39:37 +0100
| Newsgroups | gmane.comp.java.netbeans.reviewers |
|---|---|
| Message-ID | <[email protected]> |
Description:
http://netbeans.org/bugzilla/show_bug.cgi?id=223912
Refactoring undo does not work when on save tasks are enabled, and
modified the file while the refactoring was committed. This is caused by
a checksum mismatch between the supposed refactoring result and the real
on-disk content. Fixed by disabling the on save tasks while the
refactoring is being committed and undone. This might be seen unwelcome
or unexpected by some users, but the same is true for running the on
save tasks during refactoring.
Impact assessment: Undo not working for refactoring.
Risk assessment: low - the behavior should be basically the same as if
the on save tasks would be disabled in the Tools/Options.
Reviewed by Ralph Ruijs. QA verification by Jirka Prox.
Changeset:
http://hg.netbeans.org/jet-main/rev/4130b9ad2186
Thanks for review,
Jan