HR integration review request: #206513 - Does not Save Files
Miloslav Metelka <[email protected]> Thu, 31 Jan 2013 22:11:34 +0100
| Newsgroups | gmane.comp.java.netbeans.reviewers |
|---|---|
| Message-ID | <[email protected]> |
Description: http://netbeans.org/bugzilla/show_bug.cgi?id=206513 When some users modify a file in the editor the file appears to be modified normally (title marked bold) but the file cannot be saved (save action is disabled) and IDE does not ask the user for saving when either the file or the IDE gets closed. Impact assessment: For the group of users that experience the problem this is a clear dataloss. Risk assessment: low - fixed editor supports's redundant DataObject.setModified(false) which might be wrong in case the document received an additional modification during the save operation which is currently asynchronous in the IDE. Reviewed by Honza Lahoda. QA verification by Jirka Prox. Fix in HTML editor support verified to fix the problem for html files by [email protected] user. Changesets: http://hg.netbeans.org/jet-main/rev/27951a7cac21 http://hg.netbeans.org/jet-main/rev/2280c9054f2d Thanks for review, Mila