[Bug# 229720] Cannot run application client project with GlassFish 4

Tomas Kraus <[email protected]> Tue, 21 May 2013 13:31:22 +0200
Newsgroups	gmane.comp.java.netbeans.reviewers
Message-ID	<[email protected]>
This is a multi-part message in MIME format.
--------------060309010205020400050409
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

*Bug 229720* <https://netbeans.org/bugzilla/show_bug.cgi?id=229720> 
-Cannot run application client project with GlassFish 4

It is not possible to run application client project with GlassFish 4. To
reproduce:

- register GlassFish 4
- open new project wizard
- select "Java EE|Enterprise Application Client"
- finish wizard
- run project but it fails

GF4 does not support sun-acc.xml as application client container 
configuration file. It was renamed to glassfish-acc.xml. This is a show 
stopper, user can't run application client project from IDE.

changeset:   253074:a1506edbd143
summary:     #229720 - Fixed application client container configuration
              file name for GlassFish 4

Added code to provide proper file name for both GF v3 and v4.

It's quite simple change where single hard-coded file name was replaced 
by 2 options and one condition + some StringBuilder to prepare it.

Code review was done by Peter Benedikovic, QA testing by Jiri Skrivanek. 
More details are in the bug.


--------------060309010205020400050409
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

<html>
  <head>

    <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <a href="https://netbeans.org/bugzilla/show_bug.cgi?id=229720"><b>Bug&nbsp;229720</b></a>
    -<span id="summary_alias_container"> <span
        id="short_desc_nonedit_display">Cannot run application client
        project with GlassFish 4<br>
      </span></span>
    <pre class="bz_comment_text">It is not possible to run application client project with GlassFish 4. To
reproduce:

- register GlassFish 4
- open new project wizard
- select "Java EE|Enterprise Application Client"
- finish wizard
- run project but it fails</pre>
    <span id="summary_alias_container"><span
        id="short_desc_nonedit_display">GF4 does not support </span></span>sun-acc.xml
    as application client container configuration file. It was renamed
    to glassfish-acc.xml. This is a show stopper, user can't run
    application client project from IDE.
    <br>
    <pre class="bz_comment_text">changeset:   253074:a1506edbd143
summary:     #229720 - Fixed application client container configuration
             file name for GlassFish 4</pre>
    Added code to provide proper file name for both GF v3 and v4.<br>
    <br>
    It's quite simple change where single hard-coded file name was
    replaced by 2 options and one condition + some StringBuilder to
    prepare it.<br>
    <br>
    Code review was done by Peter Benedikovic, QA testing by Jiri
    Skrivanek. More details are in the bug.<br>
    <br>
  </body>
</html>

--------------060309010205020400050409--