[Bug# 229981] Cannot start GlassFish with password

Tomas Kraus <[email protected]> Wed, 22 May 2013 15:36:16 +0200
Newsgroups gmane.comp.java.netbeans.reviewers
Message-ID <[email protected]> 
This is a multi-part message in MIME format.
--------------030404020306000704020403
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

*Bug 229981* <https://netbeans.org/bugzilla/show_bug.cgi?id=229981> 
-Cannot start GlassFish with password

Problem is in GF 4 authentication response. In GF v3 HTTP admin 
interface responded with valid HTTP response (401 or 403) when wrong 
password was sent. GF v4 responds with HTTP response 200 (OK) and puts 
some exception message into returned Manifest object.
Currently java.net.Authenticator is used to handle this situation. It 
works fine with correct HTTP response (401 or 403)but does nothing for 200.
Start task for GF v4 with wrong password can't detect server status and 
kills process with "{0} start failed" where {0} is GF instance display name.

Here trunk fix is quite complicated. I have to search for special 
message in Manifestresponse and propagate it to upper layers where user 
is asked to fix admin user/password properties. I won't put such a 
complicated change into 7.3.1.

But we should provide users some information about what's going on.

changeset:   253250:a218d5957ff4
summary:Bug 229981  <https://netbeans.org/bugzilla/show_bug.cgi?id=229981>  - Cannot start GlassFish with password, simple fix for 7.3.1

This changeset just updates "{0} start failed" notification to say:

{0} start failed
Please check server admin user name and password properties.
Also please check the server log file for other possible causes.

It will at least avoid some panic and bug reports for 7.3.1.

Property change probably won't cause regressions. I asked Peter 
Benedikovic to rewiew this change. But we both are not native English 
speakers so I would like to ask UK/US guys for better message. :)

QA testing was done by Jiri Skrivanek to verify updated message in 
pop-up window.


--------------030404020306000704020403
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

<html>
  <head>

    <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <a href="https://netbeans.org/bugzilla/show_bug.cgi?id=229981"><b>Bug&nbsp;229981</b></a>
    -<span id="summary_alias_container"> <span
        id="short_desc_nonedit_display">Cannot start GlassFish with
        password<br>
        <br>
        Problem is in GF 4 authentication response. In GF v3 HTTP admin
        interface responded with valid HTTP response (401 or 403) when
        wrong password was sent. GF v4 responds with HTTP response 200
        (OK) and puts some exception message into returned Manifest
        object.<br>
        Currently java.net.Authenticator is used to handle this
        situation. It works fine with correct HTTP response </span></span><span
      id="summary_alias_container"><span id="short_desc_nonedit_display">(401
        or 403)</span></span><span id="summary_alias_container"><span
        id="short_desc_nonedit_display"> but does nothing for </span></span><span
      id="summary_alias_container"><span id="short_desc_nonedit_display">200.<br>
        Start task for GF v4 with wrong password can't detect server
        status and kills process with "</span></span>{0} start failed"
    where {0} is GF instance display name.<br>
    <span id="summary_alias_container"><span
        id="short_desc_nonedit_display"><br>
        Here trunk fix is quite complicated. I have to search for
        special message in </span></span><span
      id="summary_alias_container"><span id="short_desc_nonedit_display">Manifest</span></span><span
      id="summary_alias_container"><span id="short_desc_nonedit_display">
        response and propagate it to upper layers where user is asked to
        fix admin user/password properties. I won't put such a
        complicated change into 7.3.1.<br>
        <br>
        But we should provide users some information about what's going
        on.<br>
      </span></span>
    <pre class="bz_comment_text">changeset:   253250:a218d5957ff4
summary:     <a href="https://netbeans.org/bugzilla/show_bug.cgi?id=229981" title="REOPENED - Cannot start GlassFish with password">Bug 229981</a> - Cannot start GlassFish with password, simple fix for 7.3.1
</pre>
    This changeset just updates "{0} start failed" notification to say:<br>
    <br>
    {0} start failed<br>
    Please check server admin user name and password properties.<br>
    Also please check the server log file for other possible causes.<br>
    <span id="summary_alias_container"><span
        id="short_desc_nonedit_display"><br>
        It will at least avoid some panic and bug reports for 7.3.1.<br>
        <br>
        Property change probably won't cause regressions. I asked Peter
        Benedikovic to rewiew this change. But we both are not native
        English speakers so I would like to ask UK/US guys for better
        message. :)<br>
        <br>
        QA testing was done by </span></span><span
      class="bz_comment_user"><span class="vcard"><span class="fn">Jiri
          Skrivanek to verify updated message in pop-up window.<br>
          <br>
        </span></span></span>
  </body>
</html>

--------------030404020306000704020403--