HR fix for 236271

Ralph Benjamin Ruijs <[email protected]> Wed, 25 Sep 2013 10:23:00 +0200
Newsgroups	gmane.comp.java.netbeans.reviewers
Message-ID	<[email protected]>
This is a multi-part message in MIME format.
--------------010302040902040103000201
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Bug link:
https://netbeans.org/bugzilla/show_bug.cgi?id=236271

Description of the Bug:
Refactoring does not work if FileObject URI scheme is not "file". The 
fix changes the refactoring undo from using URLs and Files to relying on 
FileObjects.

Impact assessment:
This impacts all refactoring implementations using the refactoring.api.

Risk assessment:
Medium, all the refactoring implementations are affected and can block 
the IDE undo if something goes wrong.

Fix:
http://hg.netbeans.org/jet-main/rev/798c427194f5
http://hg.netbeans.org/jet-main/rev/25c8b84bb994

The fix was reviewed by Vladimir Kvashin and waits for verification from QE.

Thanks,
Ralph

-- 
Oracle <http://www.oracle.com>
Ralph Benjamin Ruijs | Software Developer


ORACLE Czech Republic
Green Oracle <http://www.oracle.com/commitment> Oracle is committed to 
developing practices and products that help protect the environment

--------------010302040902040103000201
Content-Type: multipart/related;
 boundary="------------050105050203010805010708"


--------------050105050203010805010708
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

<html>
  <head>

    <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    Bug link:<br>
    <a href="https://netbeans.org/bugzilla/show_bug.cgi?id=236271">https://netbeans.org/bugzilla/show_bug.cgi?id=236271</a><br>
    <br>
    Description of the Bug:<br>
    Refactoring does not work if FileObject URI scheme is not "file".
    The fix changes the refactoring undo from using URLs and Files to
    relying on FileObjects. <br>
    <br>
    Impact assessment:<br>
    This impacts all refactoring implementations using the
    refactoring.api.<br>
    <br>
    Risk assessment:<br>
    Medium, all the refactoring implementations are affected and can
    block the IDE undo if something goes wrong.<br>
    <br>
    Fix:<br>
    <a href="http://hg.netbeans.org/jet-main/rev/798c427194f5">http://hg.netbeans.org/jet-main/rev/798c427194f5</a><br>
    <a href="http://hg.netbeans.org/jet-main/rev/25c8b84bb994">http://hg.netbeans.org/jet-main/rev/25c8b84bb994</a><br>
    <br>
    The fix was reviewed by Vladimir Kvashin and waits for verification
    from QE.<br>
    <br>
    Thanks,<br>
    Ralph<br>
    <br>
    <div class="moz-signature">-- <br>
      <a href="http://www.oracle.com" target="_blank"><img
          src="cid:[email protected]" alt="Oracle"
          height="26" width="114" border="0"></a><br>
      <font face="Verdana, Arial, Helvetica, sans-serif" size="2"
        color="#666666">Ralph Benjamin Ruijs | Software Developer<br>
        <br>
        <br>
        ORACLE Czech Republic </font>
      <br>
      <a href="http://www.oracle.com/commitment" target="_blank"><img
          src="cid:[email protected]" alt="Green
          Oracle" height="28" width="44" align="absmiddle" border="0"></a>
      <font face="Verdana, Arial, Helvetica, sans-serif" size="1"
        color="#4B7D42">Oracle is committed to developing practices and
        products that help protect the environment</font>
      <!-- This signature was generated by the MyDesktop Oracle Business Signature utility version 4.1 -->
    </div>
  </body>
</html>

--------------050105050203010805010708
Content-Type: image/gif;
 name="oracle_sig_logo.gif"
Content-Transfer-Encoding: base64
Content-ID: <[email protected]>
Content-Disposition: inline;
 filename="oracle_sig_logo.gif"

R0lGODlhcgAaAMQAAP8QEP/w8P/Q0P/g4P8wMP9gYP8gIP+goP9QUP+QkP+wsP9wcP+AgP9A
QP/AwP8AAP///wAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
ACH5BAAAAAAALAAAAAByABoAAAX/ICSOZGmeaKqubOu+cCzPdC0GCqPvvBKUDp5wp1gFdIPV
IDfcOQa6A8yRaO4gweQoUHh4v2Bw4SdihM9egyBF8ALIpkEXDR44vA2XwkD/IgYGAAZbbX1n
BGRmhl8AWiUJYicCAIsPDFh4LXOGjQ4NAAhrEIUPBQcOqKmoB5sEZV4JqqoHhQVxlGAOJQG4
AAunsqg/dw95KwdfBgzBqKIEBMaQDwCiKpOwEIq6KANuJg14igZwEHPULMTGKbxetjF8D1It
xK7aKl8lCl8DAfALW1+2rUi3QtqgGN2mwYCXzYvAON624LoEQZ9DEfRcEFSBIE2DjyBDfnyI
qRgMcA8a/z5AZQWXOxEdHxwUgfIgsX/zMqlAWclVCQFefLpAqdJBAFJn3owgtpJEQkslEWjU
mYLnomokcDlS4s0eFzQNqvXDEyzmAwFPyaXYmGJBuxlzELWIacueiE0AFGyF4HbaNTquUEpF
RxUFUC9YXQzARYAkEJSNipKQ9kDu0i9SKKNZ9iXswMIoYgI4oJYFskpgzkkmcdrviELqmPVt
1HpRAaaLqCE1lBgjvEpqRtgl8Tevygd7TcCuiKvPm8OVEkAIYLYPThSsRIpEQJr1x94QBIT0
9FH6QJC6AiRAoB1kEb7tRb4MvyB+AwSlbejfz7+///8ABijggAQWaOCBCCao4A+CDDbo4IMQ
RijhhBQKGAIAOw==
--------------050105050203010805010708
Content-Type: image/gif;
 name="green-for-email-sig_0.gif"
Content-Transfer-Encoding: base64
Content-ID: <[email protected]>
Content-Disposition: inline;
 filename="green-for-email-sig_0.gif"

R0lGODlhLAAcAMQAAP///0x9RHmec9Pf0aa+oleFULHGrmKNW+nv6I+uivT39N7n3W6VZ7zP
uZu2lsjXxYSmfwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
ACH5BAAAAAAALAAAAAAsABwAQAXhICCOZGmeaDoaReC+sKAMR7GopIA6boIvLgPAVSAgALxj
SYdrOp/Q6NPgYqIEPkTBV2taTwgGbEw+PAZo3FfKbqMQQfeJ8DoY0Hg0wxhAKBgHCl5XLgMq
DwFCAAIFPIYDgidrOUQGkSh0cQMJAQyXOXKhoqOkpaanI2aoIwMErq+uCY0BMlANKpxkYwQG
BH82TpMicD0pAgQACToDAchqhAG3KQ4HIlQNnErG0IYqB9EAiEQvwEsozC43hy0CAeXMwsLD
LS8MAvf497ruCZ+gOA0gfNt3AIK0J/JWKVzIsEQIADs=
--------------050105050203010805010708--

--------------010302040902040103000201--