HR fix review #236544

libor fischmeistr <[email protected]> Tue, 01 Oct 2013 10:56:03 +0200
Newsgroups gmane.comp.java.netbeans.reviewers
Organization Oracle Corporation
Message-ID <[email protected]>
Hello,

I would ask you to review issue #236544.

Issue description:
https://netbeans.org/bugzilla/show_bug.cgi?id=236544

The system proxy settings are not properly read on Solaris system. The 
problem is in GSettings (Gnome tool). Usually on Gnome GSettings returns 
list of system settings, but on Solaris from some reason the GSettings 
returns empty list, so proxy settings cannot be read. Therefore the 
settings has to be read from gconftool-2.

How fix works:
http://hg.netbeans.org/core-main/rev/c6ad245456be

The fix now checks if the GSettings return non empty list for proxy 
schema ("org.gnome.system.proxy"). If it returns empty list, then it 
tries to use gconftool-2 and also check if gconftool-2 returns non empty 
list of properties. If gconftool-2 returns empty list, the fallback is 
used - env variable http_proxy etc. (no change in fallback).

Fix safety:
In fix there is no extra new code, basically there are two new methods 
isGconfValid and isGsettingsValid and their bodies are almost copy paste 
of an older methods getGconfMap and getGsettingsMap. But in the new 
methods the result of the return is not solved but only checked if there 
is some return.

Confirmation:
Reviewed by Standa Aubrecht - in comments
QE verification - in comments

Thanks for the review and also for any useful hints and notes.

Libor