Review #242019: [nashorn] Step out issue

Martin Entlicher <[email protected]> Thu, 20 Feb 2014 14:42:41 +0100
Newsgroups gmane.comp.java.netbeans.reviewers
Message-ID <[email protected]>
Please review the fix of bug
https://netbeans.org/bugzilla/show_bug.cgi?id=242019

Description:
The fix of issue #241016 introduced two smart-stepping related fields
steppingFromFilteredLocation and steppingFromCompoundFilteredLocation, 
that indicate whether we started stepping from a filtered location. They 
are initialized when the step request is initialized. However, in some 
cases (like Step Out), the stepping is handled by several classes. This 
has the side-effect, that these fields get initialize in the middle of 
the smart-stepping, where they unintentionally indicate, that we're 
stepping from a filtered location and therefore execution stops in the 
filtered location (like LambdaForm$MH...).

Solution:
Pass the information about stepping from the filtered location between 
the various step classes.

Impact assessment:
Step actions can unintentionally finish in classes that would normally 
be filtered out, which can bring a lot confusion to the user and it's 
hard to get back to the desired place.

Risk:
Low

http://hg.netbeans.org/core-main/rev/5cfe54085c45