Review #242054: StackOverflowError at com.sun.tools.jdi.ReferenceTypeImpl.methods

Martin Entlicher <[email protected]> Mon, 24 Feb 2014 16:03:23 +0100
Newsgroups gmane.comp.java.netbeans.reviewers
Message-ID <[email protected]>
Please review the fix of bug 
https://netbeans.org/bugzilla/show_bug.cgi?id=242054

Description:
When StackOverflowError is thrown and the program is suspended on a 
breakpoint, we call methods on the exception object to present the 
exception to the user (in Variables view).
However, when the stack is overflown, call to any method ends with 
another StackOverflowError. When that happens, debugger falls into a 
loop of getting StackOverflowError, calling getMessage() on it, getting 
another StackOverflowError, etc. It results in a StackOverflowError 
thrown from debugger and there's a significant (though temporary) impact 
on performance.

Solution:
Remember, that we call a method on an exception object and when another 
exception is thrown, stop with further retrieval of exception properties.

Impact assesment:
Usability, performance, functionality

Risk:
Low

The bugfix was reviewed and is going to be verified...

Thanks,
Martin