Re: Please review HR fix of bug 248319

--047d7bdc0d00f3b62305211f069c
Content-Type: text/plain; charset=UTF-8

Looks fine - the code should be called again any time the popup menu is
needed;  it just happens to be called from the super constructor on this
look and feel (which is dumb, as Tomas notes in the bug).

-Tim

On Fri, Oct 2, 2015 at 8:57 AM, Tomas Pavek <[email protected]> wrote:

> http://netbeans.org/issues/show_bug.cgi?id=248319
>
> A third party Look and Feel causes custom menu creation to fail in GUI
> builder, effectively disabling any context menu. It makes the GUI builder
> pretty much unusable. Although it is a bug in 3rd party component, there
> are surprisingly high number of users using it (many reports in 8.0, 8.0.1,
> 8.0.2). Workaround is simple and safe (additional check for null). Similar
> one already implemented in bug 245600.
>
> http://hg.netbeans.org/jet-main/rev/0ad8e2d4038a
>
> Thanks,
> Tomas
>



-- 
http://timboudreau.com

--047d7bdc0d00f3b62305211f069c
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Looks fine - the code should be called again any time the =
popup menu is needed; =C2=A0it just happens to be called from the super con=
structor on this look and feel (which is dumb, as Tomas notes in the bug).<=
div><br></div><div>-Tim</div></div><div class=3D"gmail_extra"><br><div clas=
s=3D"gmail_quote">On Fri, Oct 2, 2015 at 8:57 AM, Tomas Pavek <span dir=3D"=
ltr">&lt;<a href=3D"mailto:[email protected]" target=3D"_blank">tomas.=
[email protected]</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote"=
 style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><a=
 href=3D"http://netbeans.org/issues/show_bug.cgi?id=3D248319" rel=3D"norefe=
rrer" target=3D"_blank">http://netbeans.org/issues/show_bug.cgi?id=3D248319=
</a><br>
<br>
A third party Look and Feel causes custom menu creation to fail in GUI buil=
der, effectively disabling any context menu. It makes the GUI builder prett=
y much unusable. Although it is a bug in 3rd party component, there are sur=
prisingly high number of users using it (many reports in 8.0, 8.0.1, 8.0.2)=
. Workaround is simple and safe (additional check for null). Similar one al=
ready implemented in bug 245600.<br>
<br>
<a href=3D"http://hg.netbeans.org/jet-main/rev/0ad8e2d4038a" rel=3D"norefer=
rer" target=3D"_blank">http://hg.netbeans.org/jet-main/rev/0ad8e2d4038a</a>=
<br>
<br>
Thanks,<br>
Tomas<br>
</blockquote></div><br><br clear=3D"all"><div><br></div>-- <br><div class=
=3D"gmail_signature"><div><a href=3D"http://timboudreau.com" target=3D"_bla=
nk">http://timboudreau.com</a></div></div>
</div>

--047d7bdc0d00f3b62305211f069c--