Re: comments to JUnit spec

Radim Kubacki wrote:
> I have a few comments to http://ui.netbeans.org/docs/ui/junits/promo_f.html
> 
> The most important one: we are too much focused on test creating. IMO
> the test is created once and then it is sometimes updated during
> development and it should be run often.
> 
> Why do we have a dialog & wizard? Cannot we reuse one UI for all cases?

Why dialog? It is there for people who try to create (derive) a test 
class from an existing class. They look for some context menu on a Java 
file.

Why wizard? It is there for people who think like "I want to a create a 
test. When I want to create a new Java class, I invoke the New wizard. 
When I want to create a new JSP, I invoke the New wizard. So when I want 
to create a new test, I invoke..."


> Goto test case/source - dealing with more tests for one method contained
> under different test roots sounds cool but it will be pretty rare IMO
> and we should focus on more important things (just one some of these 
> tests).

I assume you refer to term "primary test". In NB 4.2, primary test is 
class having name composed of the tested class' name and the "Test" 
suffix (i.e. the same as in previous releases) and there are no 
secondary tests supported. The specification is apparently ready for the 
idea of identifying test classes also by other means than just by the 
class name (e.g. using code analysis).


> Orphaned tests - either these tests really have a value and should be
> kept or their out-of-date state will be revealed at next run test
> invocation.

I agree. This functionality will be probably removed as it would just 
upset users.


> Context menus - it is good to hear that we are going to remove tools
> action org/netbeans/modules/junit/TestsAction. I like this idea.

We plan to change it only in the context menu. In the main menu, the 
JUnit menu will still be displayed as a submenu of the Tools menu.


> I would like to remind you that there is no project window context menu. Each
> object type can have a different context menu.

Thank you for this notice.


> Placing of this action in the editor menu at the top is to courageous.
> It is not the most important action in the editor navigation.

I agree. I will discuss this with the UI engineer.


> JUnit options - I do not know how it fits into options redesign effort.

Neither me - I will need to look at it.


> The section about results is the shortest one and a lot of things is
> mising here (and in other sections too). Should the execution of tests
> use progress bar? It apparently takes some time. You have proposed more
> tabs that I would like to see and did not pay attention how the failures
> / errors / successes will be presented - plain text or formatted output.

The section about output has been reopened and the current description 
in the UI specification is not considered final.


> How can I navigate to source code / test code from a failure? How to
> rerun (only) failed test?

This was reopened, too.

Marian
(module owner of the JUnit module)