Review of Persistence UI Spec

Jan Rojcek asked for review comments.

These comments are based on Revision 1.1 of this http://j2ee.netbeans.org/docs/promog/persistence-ui-spec.html

Good start.

Use-cases need more detail.  It is easir to understand some of the detailed ascii-art with a more complete fleshed out context.

1. Source menu... 

Since the Convert to Entity Class command affects the whole class, you may want to move it UP.

The action that have the closest parallel results (in this menu) is Fix Imports

2. New Enterprise Application  -- Name and Location

What does the Manage button do?

Java EE 5 relies on J2SE 5.0 annotations.  The note on the Set Source Level to 1.4 checkbox is just plain incorrect.

3. New EJB module -- Name and Location

Manage and source level commments apply here In BOTH designs.

Alternate design comment:

If the user selects the add to enterprise app radio button, should we reset and disable the project location field?

4. New Web Application -- Name and Location

Commments from EJB Module apply here, too.

5. New File in EJB Project -- Choose File Type

I don't think an Entity Class is an Enterprise object...  Isn't it just a Java Class?

6. New Entity Classs -- Name and Location

It is really hard to understand this dialog/wizard without a clear statement of WHAT clicking finish produces.

It looks like  you are using this wizard to create a class that will have some entity annotation, but that isn't currently associated with a TABLE...

Is the Persistence field used to describe where the user wants the TABLE that is associated with this class to be located?

If it is Persistence is probably not the best label...

7.  Convert to Entity Class dialog

What does the Persistence field mean here???

8. Persistence hint

What happens when the user executes this hint?

vbk