[JIRA-OS] Commented: (WW-299) AbstractUITag.doEndTag() doesn't assign null to actualValue

The following comment has been added to this issue:

     Author: Scott Farquhar
    Created: Tue, 9 Sep 2003 1:38 AM
       Body:
You should not 'null' variables in doEndTag.  Ever.  Just don't do it.

Setters & getters should set simple values.  These values should be evaluated in doStartTag (but not changed).

Read these guidelines:

http://jakarta.apache.org/taglibs/guidelines.html
---------------------------------------------------------------------
View the issue:

  http://jira.opensymphony.com/secure/ViewIssue.jspa?key=WW-299


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: WW-299
    Summary: AbstractUITag.doEndTag() doesn't assign null to actualValue
       Type: Bug

     Status: Assigned
   Priority: Critical

    Project: WebWork
 Components: 
             Component Management
   Versions:
             2.0-beta2

   Assignee: Patrick Lightbody
   Reporter: Scott N. Smith

    Created: Mon, 8 Sep 2003 6:24 PM
    Updated: Mon, 8 Sep 2003 6:24 PM
Environment: Weblogic 6.1 SP4 but this isn't important

Description:
In AbstractUITag, method doEndTag() neglects to assign null to instance "actualValue".  This manifests itself by, on a form with more than one input field, input fields after the first one are not rendered correctly from the instance variables.

Also, why isn't the common variable resetting (i.e. assigning to null) found in doEndTag() and release() combined into a common method (say doNull())?


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.opensymphony.com/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf