[JIRA-OS] Commented: (WF-206) AbstractWorkflow.getVariablesFromMaps unsafe use of PropertySet

The following comment has been added to this issue:

     Author: Hani Suleiman
    Created: Wed, 10 Sep 2003 1:18 PM
       Body:
Hm, the problem is that this would cause each call to take twice as long, propertysets are slow enough as it is without making them twice as slow!

---------------------------------------------------------------------
View the issue:

  http://jira.opensymphony.com/secure/ViewIssue.jspa?key=WF-206


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: WF-206
    Summary: AbstractWorkflow.getVariablesFromMaps unsafe use of PropertySet
       Type: Bug

     Status: Assigned
   Priority: Major

    Project: OSWorkflow

   Assignee: Patrick Lightbody
   Reporter: Robert Dawson

    Created: Wed, 3 Sep 2003 11:30 AM
    Updated: Wed, 3 Sep 2003 11:30 AM

Description:
The AbstractWorkflow.getVariablesFromMaps does a straight lookup of the String against the propertyset.  The OFBizPropertySet throws a 
PropertyImplementationException when the property doesn't exist.

I suggest that AbstractWorkflow.getVariablesFromMaps should change:

        if (o == null) {
            o = ps.getAsActualType(actualVar);
        }

to be:
        if (o == null) {
            if (ps.exists(actualVar)){
                o = ps.getAsActualType(actualVar);
            }
        }



---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.opensymphony.com/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf