[JIRA-OS] Commented: (WF-215) BeanShellFunctionProvider exception logging misses key info!

The following comment has been added to this issue:

     Author: Hani Suleiman
    Created: Sat, 13 Sep 2003 3:22 PM
       Body:
I'm not sure I see the problem. Looking over the code, the beanshell error is propagated upwards, is the problem that it has an error in it that isn't shown? Also, printing anythign to the console is not acceptable, the correct approach would be to have the error bubble upwards and show somethign meaningful to the user.

Can you attach a trivial example workflow with a beanshell error, and say what exception it gives and how that differs from what it's expected to give?
---------------------------------------------------------------------
View the issue:

  http://jira.opensymphony.com/secure/ViewIssue.jspa?key=WF-215


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: WF-215
    Summary: BeanShellFunctionProvider exception logging misses key info!
       Type: Bug

     Status: Assigned
   Priority: Major

    Project: OSWorkflow
 Components: 
             FunctionProviders
   Versions:
             2.6

   Assignee: Hani Suleiman
   Reporter: Eric Pugh

    Created: Sat, 13 Sep 2003 9:05 AM
    Updated: Sat, 13 Sep 2003 9:05 AM

Description:
Hi all,
In the example.xml unit test, I am having a problem in the BeanShell section:
 String caller = context.getCaller();
                                propertySet.setString("caller", caller);
                                boolean test = true;
                                String yuck = null;
                                String blah = "987654321";
                                System.out.println("$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$");

In the JDBCFunctionalWorkflowTestCase it fails due to a JDBC error I had.  Unfortunantly, that error is eaten, and instead I just get an error saying:

Target exception: java.lang.NullPointerException

	at com.opensymphony.workflow.util.beanshell.BeanShellFunctionProvider.execute(BeanShellFunctionProvider.java:64)

But, what I really want is something telling me that it was a JDBC error:
java.lang.NullPointerException
	at com.opensymphony.module.propertyset.database.JDBCPropertySet.setImpl(JDBCPropertySet.java:267)
	at com.opensymphony.module.propertyset.AbstractPropertySet.set(AbstractPropertySet.java:565)

So, I can't seem to get that error to log, the best I could do was add this line: 

evalError.fillInStackTrace().printStackTrace(); 

to at least output the error somehow...  I don't really understand the whole fillInStackTrace() stuff..   I couldn't get it to log though.  If you agree, I can attach a patch that adds the key line, and provide a unit test as well.



---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.opensymphony.com/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf