[JIRA-OS] Commented: (WF-195) Steps should not have a different id when moved to history

The following comment has been added to this issue:

     Author: Hani Suleiman
    Created: Sun, 14 Sep 2003 7:38 PM
       Body:
Alright, I don't know Hibernate at all, but looking over the code, it looks like this is already done?

The HibernateHistoryStep is created with the same properties are the input Step, and the input step is removed from the list of current steps for the entry, then the entry saved (thus persisting the history and current steps).

Am I missing something?
---------------------------------------------------------------------
View the issue:

  http://jira.opensymphony.com/secure/ViewIssue.jspa?key=WF-195


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: WF-195
    Summary: Steps should not have a different id when moved to history
       Type: Bug

     Status: Assigned
   Priority: Major

    Project: OSWorkflow
 Components: 
             Core
   Versions:
             2.5

   Assignee: Patrick Lightbody
   Reporter: Peter Mayne

    Created: Tue, 12 Aug 2003 9:39 PM
    Updated: Tue, 12 Aug 2003 9:39 PM

Description:
The following happens when using the Hibernate store. 

A new workflow step is created with instance id (say) 10. 

doAction() is called. The workflow step with instance id 10 is removed from the current step table and added to the history step with id (say) 11. The step should have the same id in the history table as it had in the current table.

The final try block in HibernateWorkflowStore.moveToHistory should contain a save() with an explicit id:

        try
        {
            // PJDM create new history step with the same id.
            //
            session.save(hStep, new Long(hStep.getId()));
            session.delete(step);
            
            session.save(entry);
            tx.commit();
        }
        catch (HibernateException he)
        {
            log.error("Saving workflow entry " + entry.getId(), he);
            throw new StoreException("Saving workflow entry " + entry.getId(), he);
        }

Note that this also deletes the step from the current table, which is currently not being done.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.opensymphony.com/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf