[JIRA-Opensymphony] Created: (WF-178) Script arg text should be able to contain XML comments

Message:

  A new issue has been created in JIRA.

---------------------------------------------------------------------
View the issue:

  http://jira.opensymphony.com/secure/ViewIssue.jspa?key=WF-178


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: WF-178
    Summary: Script arg text should be able to contain XML comments
       Type: Bug

     Status: Assigned
   Priority: Minor

    Project: OSWorkflow
   Versions:
             2.5

   Assignee: Patrick Lightbody
   Reporter: sean schofield

    Created: Sat, 12 Jul 2003 10:22 AM
    Updated: Sat, 12 Jul 2003 10:22 AM
Environment: Windows XP, PostgresSQL, ApacheTomcat 4.1.12, Latest CVS source code

Description:
I was experimenting with the example and I modified one of the arguments in order to test split#2.  I did so by changing the XML and I thought everything was working fine (b/c I saw the split and the caller was not "bogus".)  Then I tried to change things back by commenting out my added code and restoring the original code as shown here:

<arg name="script">
<!-- modified to ensure split#2 was result -->
<!--
propertySet.getString("caller").equals("bogus")
-->
propertySet.getString("caller").equals("test")
</arg>

I was suprised to see that the result was the same.  I guessed that the problem was with the comment.  I tested this by removing the comment and verifiying that things worked correctly.

An XML comment here should not impede the propper functioning of the engine.  After examing some of the source code I think this project could benefit from using CommonsDigester which will help reduce some of the parsing complexity.  I think I might have some time to help out with this if people are interested.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.opensymphony.com/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira



-------------------------------------------------------
This SF.Net email sponsored by: Parasoft
Error proof Web apps, automate testing & more.
Download & eval WebKing and get a free book.
www.parasoft.com/bulletproofapps1