RE: A couple of OSUser questions
"Eric Pugh" <[email protected]> Sat, 6 Dec 2003 20:21:07 -0000
| Newsgroups | gmane.comp.java.open-symphony.devel |
|---|---|
| Message-ID | <003901c3bc36$7bbee5f0$0f8315ac@IQUITOS> |
Re: [Opensymphony-developers] A couple of OSUser questionsI didn't realize we where talking about using <composite-id>, as I agree, we shouldn't use it. However, the magic of Hibernate is that if my user requires it, then in my implementation I can use a <composite-id> as long as my mapping loads instead of the default one. I think that all he meant was to use Long versus long as the id, which would still have the same mapping... Eric -----Original Message----- From: Matthew E. Porter [mailto:[email protected]] Sent: Saturday, December 06, 2003 7:56 PM To: [email protected] Subject: Re: [Opensymphony-developers] A couple of OSUser questions As quoting from Hibernate Documentation: "There is an alternative <composite-id> declaration to allow access to legacy data with composite keys. We strongly discourage its use for anything else." Can we please hold off applying the foreign PK patch until more people have chimed in? Cheers, matthew On Dec 6, 2003, at 1:44 PM, Eric Pugh wrote: Brian, I actually lean towards the PK being an object as well. I prefer to be able to know that getting a PK which is null means it hasn't been saved, versus knowing the 0 means unsaved. Especially as 0 is a perfectly good ID value! Which bug report was yours? I'll look at your patch and apply it, do you just want to one patch for all your changes? Eric -----Original Message----- From: [email protected] [mailto:[email protected]]On Behalf Of Brian Topping Sent: Saturday, December 06, 2003 7:16 PM To: [email protected] Subject: [Opensymphony-developers] A couple of OSUser questions Hi all, Back from some extended time away from the keys. Doing some travel and carpentry and things of that nature. It's fun to be back. Hope all your holidays are going well. Just getting recent versions of the code down and was psyched to see Hibernate support in OSUser. I've been working a bit with it in the last 24 hours and filed one bug on it last night. I have the fixes for it, but it will take longer for someone to use them than it will for someone with IDEA and a RW connection to CVS to do the changes over again. It took me about 30 minutes on this side. The other one, I'm not so sure it's a bug or not, it smells a lot like it belongs in the space of "conventions" rather than bug. So I thought I would ask for some rationale. In the CMP world, primary keys are objects instead of primitives. I've been following that through to Hibernate since it looks like composite types require that as well. But BaseHibernateEntity defines the PK as a primitive long. Any comments on why this would be beneficial? Otherwise, my vote is to convert to object PKs and am happy to do the work on it. thanks, -b ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. Does SourceForge.net help you be more productive? Does it help you create better code? SHARE THE LOVE, and help us help YOU! Click Here: http://sourceforge.net/donate/ _______________________________________________ Opensymphony-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensymphony-developers <winmail.dat>