RE: OSUser DAO (was: A couple of OSUser questions)

Hi Matthew,

I just posted something on the converting the PK to an object.  I'll change
the name of this thread.

If the DAO didn't exist, I would agree with you. But given that I can use the
DAO to access my own objects (i.e. from my current db schema) instead of
modifying my schema to adapt to OSUser's idea of the schema, I took advantage
of it. 

The DAO appears to be something that Mike added, after your initial checkin I
presume, so I can understand if there may be a disconnect.  It adds
significantly to the complexity of the code considering how little
documentation is available on it.  But it's a cool feature and a "net good"
in my book.  I quite like the flexibility it provides when it is working.

Using the DAO future-proofs applications that want to keep the OSUser library
up-to-date without having to change their schema if/when the OSUser/Group
objects change.  Which is good for OSUser developers because the user base
doesn't have to be so tightly coupled to the database schema.  In my case, I
just don't want to use the provided user/group objects, and the DAOs allow me
to change that if they are set up correctly.

best,

-b

> -----Original Message-----
> From: Matthew E. Porter [mailto:[email protected]]
> Sent: Saturday, December 06, 2003 2:51 PM
> To: [email protected]
> Subject: Re: [Opensymphony-developers] A couple of OSUser questions
> 
> 
> Brian:
>    I wrote the initial implementation of the Hibernate provider.  
> Granted, that and $.35 will get me a phone call and nothing 
> else.  Here 
> is my opinion though.
> 
>    I don't know if I see a reason to extract interfaces for 
> HibernateUser and HibernateGroup since they are already 
> facaded by User 
> and Group, respectively.  The only reason I see for doing 
> this would be 
> to change the PK or the way the HibernateUser and HibernateGroup are 
> associated.
> 
>    Regarding changing the PK to a composite type, I don't see 
> a reason 
> for doing this.  Can you explain why one would need a composite key?  
> Hibernate mainly has this feature for legacy tables, not when one is 
> creating new ones (as in this case).  I believe this is very 
> anti-Hibernate as well.
> 
> That doesn't mean I am against it.  I am just not convinced.
> 
> 
> Cheers,
>    matthew
> 
> On Dec 6, 2003, at 1:15 PM, Brian Topping wrote:
> 
> > Hi all,
> >
> > Back from some extended time away from the keys.  Doing 
> some travel and
> > carpentry and things of that nature.  It's fun to be back.  
> Hope all 
> > your
> > holidays are going well.
> >
> > Just getting recent versions of the code down and was psyched to see
> > Hibernate support in OSUser.  I've been working a bit with 
> it in the 
> > last 24
> > hours and filed one bug on it last night.  I have the fixes for it, 
> > but it
> > will take longer for someone to use them than it will for 
> someone with 
> > IDEA
> > and a RW connection to CVS to do the changes over again.  
> It took me 
> > about 30
> > minutes on this side.
> >
> > The other one, I'm not so sure it's a bug or not, it smells 
> a lot like 
> > it
> > belongs in the space of "conventions" rather than bug.  So 
> I thought I 
> > would
> > ask for some rationale.
> >
> > In the CMP world, primary keys are objects instead of primitives.  
> > I've been
> > following that through to Hibernate since it looks like 
> composite types
> > require that as well.  But BaseHibernateEntity defines the PK as a 
> > primitive
> > long.
> >
> > Any comments on why this would be beneficial?  Otherwise, 
> my vote is to
> > convert to object PKs and am happy to do the work on it.
> >
> > thanks,
> >
> > -b
> >
> >
> > -------------------------------------------------------
> > This SF.net email is sponsored by: SF.net Giveback Program.
> > Does SourceForge.net help you be more productive?  Does it
> > help you create better code?  SHARE THE LOVE, and help us help
> > YOU!  Click Here: http://sourceforge.net/donate/
> > _______________________________________________
> > Opensymphony-developers mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/opensymphony-developers
> 
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: SF.net Giveback Program.
> Does SourceForge.net help you be more productive?  Does it
> help you create better code?  SHARE THE LOVE, and help us help
> YOU!  Click Here: http://sourceforge.net/donate/
> _______________________________________________
> Opensymphony-developers mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/opensymphony-developers
> 


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/