Re: [OT] OSUser : getting started
Mike Cannon-Brookes <[email protected]> Thu, 11 Dec 2003 23:17:22 +1100
| Newsgroups | gmane.comp.java.open-symphony.devel |
|---|---|
| Message-ID | <BBFEAB82.3DDAC%[email protected]> |
The constructors are public so that you can easily create a test UserManager
(new UserManager("test-osuser.xml") for use in unit tests. Please do not
make them private :)
Cheers,
Mike
On 11/12/03 11:00 PM, "J. Matthew Pryor" ([email protected]) penned
the words:
> Yeah will given the constructor throws a custom runtime exception, perhaps
> that should be simply thrown on
>
> If I'm nit-picking, then the constructors probably shouldn't be public if
> getInstance() is public, in which case it probably should throw a checked
> exception
>
> Anyway I guess that's all a bit theoretical
>
> I'd be happy to pitch in & make changes, but there are public APIs to
> consider I guess ...
>
> Matthew
>
>> -----Original Message-----
>> From: [email protected]
>> [mailto:[email protected]]On Behalf Of
>> Nick Faiz
>> Sent: Thursday, December 11, 2003 5:02 PM
>> To: '[email protected]'
>> Subject: RE: [Opensymphony-developers] [OT] OSUser : getting started
>>
>>
>> Yes, it's a little worrying to see the null being returned.
>>
>> I've recently been re-factoring an application which did exactly what you
>> have pointed out, plus logged an error. There was no documentation
>> specifying that we should run Log4J to report errors, I usually set it to
>> run at fatal, and the client simply ignored a null result - it
>> wasn't a fun
>> exception to track down.
>>
>> Nick
>>
>> -----Original Message-----
>> From: J. Matthew Pryor [mailto:[email protected]]
>> Sent: Thursday, 11 December 2003 4:43 PM
>> To: [email protected]
>> Subject: RE: [Opensymphony-developers] [OT] OSUser : getting started
>>
>> OK well I ended up having to make quite a few changes to build.xml as it
>> came out of [email protected]
>>
>> Some of those relate to the fact that I am using Eclipse, but some of them
>> AFAICT the build.xml file just couldn't have worked, so I am a
>> bit confused
>>
>> I have attached my changes for anyone who is interested to review
>>
>> After that, my 2nd problem was an RTFM issue, since I hadn't included
>> osuser.xml on the classpath of the example.ear
>>
>> On the feedback front, there was a bit of code in UserManager that got me
>>
>> /**
>> * Entry-point to Singleton instance
>> */
>> public static UserManager getInstance() {
>> try {
>> if (instance == null) {
>> instance = new UserManager();
>> }
>> } catch (RuntimeException e) {
>> return null;
>> }
>>
>> return instance;
>> }
>>
>> The runtime exception in this case was reporting the fact that the
>> osuser.xml file could not be loaded, and its a bit nasty to just toss the
>> exception away like that
>>
>> At the very least a logger.error() would have been nice. I can send diffs
>> for my changes if somone wants to review/commit them
>>
>> Thanks for the offers of help. I am up & running now
>>
>> BTW I am planning on putting together maven build files for OSUser for my
>> own use, any interest in me submitting it?
>>
>> Matthew
>>
>>> -----Original Message-----
>>> From: [email protected]
>>> [mailto:[email protected]]On Behalf Of
>>> Matthew E. Porter
>>> Sent: Thursday, December 11, 2003 1:57 PM
>>> To: [email protected]
>>> Subject: Re: [Opensymphony-developers] [OT] OSUser : getting started
>>>
>>>
>>> We are using for internal applications and it works beautifully. If
>>> you have any specific questions, ask the list. Someone here will be
>>> happy to respond.
>>>
>>>
>>> Cheers,
>>> matthew
>>>
>>> On Dec 10, 2003, at 8:39 PM, Hani Suleiman wrote:
>>>
>>>> The example should work, please do holler here if it doesn't run.
>>>> While not much development is going in it right now, quite a few
>>>> people are using it.
>>>>
>>>> On Dec 10, 2003, at 9:24 PM, Nick Faiz wrote:
>>>>
>>>>> Matthew,
>>>>>
>>>>> You're not the only one interested in taking first steps
>>>>> with OSUser.
>>>>>
>>>>> If you are successful with building the example and
>>>>> making things work, please let me know. I would like to do the same
>>>>> myself, quite soon.
>>>>>
>>>>>
>>>>>
>>>>> Nick
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> -----Original Message-----
>>>>> From:J. Matthew Pryor [mailto:[email protected]]
>>>>> Sent:Thursday, 11 December 2003 1:19 PM
>>>>> To:[email protected]
>>>>> Subject:[Opensymphony-developers] [OT] OSUser : getting started
>>>>>
>>>>>
>>>>>
>>>>> Sorry if this is the wrong place, but the dev list was the only
>>>>> archive I could find recent posts on relating to OSUser
>>>>>
>>>>>
>>>>>
>>>>> Is OSUser active? The lists at java.net seem dead
>>>>>
>>>>>
>>>>>
>>>>> I am trying to build the example after getting the source
>>>>> [email protected] the readme appears to be pretty out of date
>>>>>
>>>>>
>>>>>
>>>>> If I have missed something obvious or should post elsewhere, please
>>>>> let me know
>>>>>
>>>>>
>>>>>
>>>>> Again apologies for the OT post
>>>>>
>>>>>
>>>>>
>>>>> Matthew
>>>>
>>>>
>>>>
>>>> -------------------------------------------------------
>>>> This SF.net email is sponsored by: SF.net Giveback Program.
>>>> Does SourceForge.net help you be more productive? Does it
>>>> help you create better code? SHARE THE LOVE, and help us help
>>>> YOU! Click Here: http://sourceforge.net/donate/
>>>> _______________________________________________
>>>> Opensymphony-developers mailing list
>>>> [email protected]
>>>> https://lists.sourceforge.net/lists/listinfo/opensymphony-developers
>>>
>>>
>>>
>>> -------------------------------------------------------
>>> This SF.net email is sponsored by: SF.net Giveback Program.
>>> Does SourceForge.net help you be more productive? Does it
>>> help you create better code? SHARE THE LOVE, and help us help
>>> YOU! Click Here: http://sourceforge.net/donate/
>>> _______________________________________________
>>> Opensymphony-developers mailing list
>>> [email protected]
>>> https://lists.sourceforge.net/lists/listinfo/opensymphony-developers
>>
>>
>> -------------------------------------------------------
>> This SF.net email is sponsored by: SF.net Giveback Program.
>> Does SourceForge.net help you be more productive? Does it
>> help you create better code? SHARE THE LOVE, and help us help
>> YOU! Click Here: http://sourceforge.net/donate/
>> _______________________________________________
>> Opensymphony-developers mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/opensymphony-developers
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: SF.net Giveback Program.
> Does SourceForge.net help you be more productive? Does it
> help you create better code? SHARE THE LOVE, and help us help
> YOU! Click Here: http://sourceforge.net/donate/
> _______________________________________________
> Opensymphony-developers mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/opensymphony-developers
-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive? Does it
help you create better code? SHARE THE LOVE, and help us help
YOU! Click Here: http://sourceforge.net/donate/