RE: osuser hibernate providers

I was looking at the use of xdoclet, and I don't think it is a problem since
regardless of whether you use xdoclet or a hand generated .hbm.xml files,
they will still end up in the osuser jar file.  If you are overriding them,
then the right way is to reference your own .hbm.xml file, ignoring the ones
in the jar.  That way users who are starting from scratch can use the
default osuser schema, but other users can reference their own schema.

I don't think we want users to have to edit the existing default mapping
file and jar up a custom version?

Also, I think what is confusing about the extra interfaces is just that they
aren't used anywhere in the docs.  So, out of the box it looks a bit
confusing..  I think based on the emails over the weekend, this clarifies
that the DAO's should stay, and the interfaces don't hurt anything.

I think on USER-41 that null is the clearest way of checking unsaved.  After
all, -1 and 0 are (arguably) both valid values for an id...  Checking
user.getId()==null is the clearest, and I don't think should affect
performance in any signficant way..  As an aside, I couldn't read the diff:
http://jira.opensymphony.com/secure/attachment/10302/base_entity.diff, I get
a file not found error...

Eric

> -----Original Message-----
> From: [email protected]
> [mailto:[email protected]]On
>  Behalf Of
> Mike Cannon-Brookes
> Sent: Monday, December 22, 2003 1:36 AM
> To: opensymphony-developers
> Subject: Re: [Opensymphony-developers] osuser hibernate providers
>
>
> Personally I'm strongly against putting the mappings in
> Xdoclet tags, it
> makes the build more complicated and if you're using
> Hibernate with OSUser
> you're most likely going to use your own mapping files
> (created from the
> OSUser ones) than use the default ones provided.
>
> As for the issues, let me look at them now (I found 5):
>
> USER-54 - Yes, the default is braindead because it needs to
> be. Anyone using
> Hibernate + OSUser is strongly recommended to write their own DAOs and
> ConfigurationProvider implementations to use your own Session
> management
> strategy (ie ThreadLocal, Spring or whatever).
>
> USER-53 - I don't know about this one (we use the
> ProfileProvider and it
> works - see above for suggestions!), but if the patch works it seems
> reasonable to me.
>
> USER-46 - well this again comes down to architecture choices
> really. As I
> said, it works for me as it is now - but I'd like to hear
> input from Matt /
> Brian as to the problems they have with how things work now.
>
> USER-49 - seems to be still under discussion. Personally I
> agree with Matt
> that the extra degree of Interfaces is probably not needed
> (at least for my
> use cases), but I could live with if needed?
>
> USER-41 - I'm not sure this is needed, as the unsaved-value
> of long should
> just be -1 or something?
>
> Mike
>
>  On 22/12/03 10:51 AM, "J. Matthew Pryor"
> ([email protected]) penned
> the words:
>
> > Well I have patches to put the mappings into xdoclet tags
> >
> > I assume I can find the issue jira, I'll take a look
> >
> > jmp
> >
> >> -----Original Message-----
> >> From: [email protected]
> >>
> [mailto:[email protected]]On
>  Behalf Of
> >> Hani Suleiman
> >> Sent: Monday, December 22, 2003 10:47 AM
> >> To: [email protected]
> >> Subject: [Opensymphony-developers] osuser hibernate providers
> >>
> >>
> >> Alright, all you hibernate kids, time to sort out the mess
> in osuser!
> >>
> >> Right now there are four open issues in osuser relating to the
> >> hibernate providers. From my outside non-hibernate using
> point of view,
> >> it looks like no two people can agree on how to use hibernate. This
> >> can't be that hard, surely there's a standard way that everyone can
> >> stick to?
> >>
> >> So, what I'd like is for anyone who cares to come up with
> patches with
> >> issues that affect them, and attach them to the issues.
> I'll commit the
> >> patches and resolve the issues.
> >>
> >> Basically, if you care enough, fix it. Those who care and give a
> >> working solution get the benefit of having it work their
> way. Those who
> >> care and don't give a working solution have to live with what other
> >> hibernate users decided.
> >>
> >> Hani
> >>
> >>
> >>
> >> -------------------------------------------------------
> >> This SF.net email is sponsored by: IBM Linux Tutorials.
> >> Become an expert in LINUX or just sharpen your skills.
> Sign up for IBM's
> >> Free Linux Tutorials.  Learn everything from the bash
> shell to sys admin.
> >> Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click
> >> _______________________________________________
> >> Opensymphony-developers mailing list
> >> [email protected]
> >>
> https://lists.sourceforge.net/lists/listinfo/opensymphony-developers
> >
> >
> > -------------------------------------------------------
> > This SF.net email is sponsored by: IBM Linux Tutorials.
> > Become an expert in LINUX or just sharpen your skills.
> Sign up for IBM's
> > Free Linux Tutorials.  Learn everything from the bash shell
> to sys admin.
> > Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click
> > _______________________________________________
> > Opensymphony-developers mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/opensymphony-developers
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: IBM Linux Tutorials.
> Become an expert in LINUX or just sharpen your skills.  Sign
> up for IBM's
> Free Linux Tutorials.  Learn everything from the bash shell
> to sys admin.
> Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click
> _______________________________________________
> Opensymphony-developers mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/opensymphony-developers



-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills.  Sign up for IBM's
Free Linux Tutorials.  Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click