Re: [PR] TOMEE-4432 - MicroProfile 6.1 (tomee)

rzo1 (via GitHub) <[email protected]>
Newsgroups gmane.comp.java.openejb.devel
Message-ID <PR_kwDOAHY68M6TuqoW-27d9fd76-3ac1-4387-bcd2-eb2677a02a53@gitbox.apache.org>
rzo1 commented on code in PR #1898:
URL: https://github.com/apache/tomee/pull/1898#discussion_r2069354273


##########
tck/microprofile-tck/metrics/src/test/java/org/apache/tomee/microprofile/tck/metrics/MicroProfileMetricsTCKDeploymentPackager.java:
##########
@@ -38,9 +38,14 @@ public Archive<?> generateDeployment(final TestDeployment testDeployment,
                                          final Collection<ProtocolArchiveProcessor> processors) {
         final Archive<?> applicationArchive = testDeployment.getApplicationArchive();
         final WebArchive wrapperWar = ShrinkWrap.create(WebArchive.class, "microprofile-metrics.war");
-        if (applicationArchive instanceof JavaArchive) {
-            wrapperWar.addAsLibrary(applicationArchive);
-            return super.generateDeployment(new TestDeploymentDelegate(testDeployment, wrapperWar), processors);
+
+        // Move microprofile-config.properties from /META-INF/ to /WEB-INF/classes/META-INF/
+        // cf. https://github.com/microprofile/microprofile-config/issues/268
+        // cf. https://github.com/microprofile/microprofile-config#design <- should be on the class path which is /WEB-INF/classes in a WAR file
+        if (applicationArchive.contains("META-INF/microprofile-config.properties")) {

Review Comment:
   https://github.com/microprofile/microprofile-metrics/issues/803



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.