Re: [PR] TOMEE-4516 - Threadsafe RequestScopedThreadContextL istener (tomee)
jungm (via GitHub) <[email protected]>
| Newsgroups | gmane.comp.java.openejb.devel |
|---|---|
| Message-ID | <PR_kwDOAHY68M6cr49w-f002db5a-7b31-478c-a87b-2761386467c1@gitbox.apache.org> |
jungm commented on PR #1996:
URL: https://github.com/apache/tomee/pull/1996#issuecomment-3130863438
quick side note, the commit that caused all this is https://github.com/apache/tomee/pull/1458/commits/fb6340de805c5454d61d9bbadf25f5fcad730ee3
I'm not exactly sure anymore why i chose to do it this way, but removing it now makes the concurrency TCK fail:
```
[ERROR] Failures:
[ERROR] TransactionTests>Arquillian.run:137->testCancelTransactionWithManagedScheduledExecutorService:89->TestClient.runTest:70->TestClient.assertSuccessfulURLResponse:143->ArquillianTests.assertTrue:108 Output did not contain successful message: SUCCESS expected [true] but found [false]
[ERROR] TransactionTests>Arquillian.run:137->testRollbackTransactionWithManagedScheduledExecutorService:72->TestClient.runTest:70->TestClient.assertSuccessfulURLResponse:143->ArquillianTests.assertTrue:108 Output did not contain successful message: SUCCESS expected [true] but found [false]
[INFO]
[ERROR] Tests run: 147, Failures: 2, Errors: 0, Skipped: 1
```
Might need to look at this again and figure out another way to pass these tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]