RE: RE: Admin API and GUI
"Tim Anderson" <[email protected]>
| Newsgroups | gmane.comp.java.openjms.devel |
|---|---|
| Message-ID | <[email protected]> |
> From: openjms-developer-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org > [mailto:openjms-developer-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org]On Behalf Of Knut at work <snip> > Personaly I prefer the API to contain the connect(), disconnect() insted of > having the the connect() delivering the API and then only have close() > (or disconnect() ) represented inside the API. > Anyway this is not a big deal :-) But if we do it like you described I > suggest that we rename connect() to createConnection(). Providing an AdminConnection.connect() method is a code smell. With this approach you use the AdminConnectionFactory to get the connection, but then have to invoke connect() before you can use any of the methods. And if you disconnect(), can you reconnect again, and if so, why would you want to? <snip> > Could you provide the checkstyle-config file? Its available in CVS - or will be in 24 hours. See checkstyle.properties in the root directory.