[ openjms-Bugs-1040962 ] Singleton pattern not implemented properly in DestinationMan

Bugs item #1040962, was opened at 2004-10-05 16:19
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=474136&aid=1040962&group_id=54559

Category: None
Group: v0.7.6.1
Status: Open
Resolution: None
Priority: 5
Submitted By: sshearer (kungfucode)
Assigned to: Nobody/Anonymous (nobody)
Summary: Singleton pattern not implemented properly in DestinationMan

Initial Comment:
The _instance member is declared static, however,
multiple calls to createInstance will continually
create new DestinationManager objects and assign their
references to _instance.  With createInstance being
callable from anywhere, it is public after all, this
leaves the door open for potentially difficult to
diagnose concurrency issues down the road.

Recommend checking for null value in createInstance and
only creating a new object if the Singleton reference
_instance has yet to be initialized.  

Also recommend synchronizing the method createInstance
to protect against problems stemming from calls to the
method by multiple threads.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=474136&aid=1040962&group_id=54559


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl